This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
feat(algebra/order/ring/lemmas): use typeclass zero_le_one_class
#18158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e namespace `without_zero_le_one` The fourth part of #16449 There are still some useless lemmas which were simply ported from `algebra/order/monoid_lemmas`, this PR removes them. Also some lemmas have both assumptions like `1 < a` `0 < a`, this is because the file does not use type classes like `zero_le_one_class` currently. So I put these lemmas in the namespace `without_zero_le_one`.
FR-vdash-bot
added
awaiting-review
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
|
This PR/issue depends on: |
FR-vdash-bot
removed
the
awaiting-CI
eric-wieser
added
the
not-too-late
FR-vdash-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 23, 2023
|
Closing in favor of leanprover-community/mathlib4#9250 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib4 PR: (TODO, blocked by other PR now)
without_zero_le_one#16525