-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
456 fe content panel improvements in navigation #461
456 fe content panel improvements in navigation #461
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitkapanarin Please clean up this PR. I know you were working on the Invite Member ticket for the admin-panel, and I can see you transferred all that code to this branch as well.
This branch and the ticket that corresponds to it should be only for content panel and the navigation.
Rerequest review when you have changed this. 🙏
@@ -6,7 +6,7 @@ jobs: | |||
timeout-minutes: 60 | |||
runs-on: ubuntu-latest | |||
env: | |||
BASE_URL: 'http://localhost:3000' | |||
BASE_URL: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this change. Why was this necessary?
@mitkapanarin should we close this PR, as I see you created a new one? |
Yes, I created a new branch and made all the changes there. Is that okay?
Sent from Yahoo Mail for iPhone
On Sunday, December 8, 2024, 4:33 PM, Emilija Dichoska ***@***.***> wrote:
@mitkapanarin should we close this PR, as I see you created a new one?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yes, ofcourse. Just wanted to double check if I can close this PR. |
Duplicate |
This commit updates the Navigation component, introducing several new features and improvements:
Conditional Rendering:
Content Panel Navigation:
User Authentication Features:
Improved User Experience: