Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

456 fe content panel improvements in navigation #461

Closed

Conversation

mitkapanarin
Copy link

@mitkapanarin mitkapanarin commented Dec 3, 2024

This commit updates the Navigation component, introducing several new features and improvements:

  1. Conditional Rendering:

    • Implemented logic to differentiate between public navigation and content panel navigation
    • The component now adapts its display based on the current route
  2. Content Panel Navigation:

    • Added specific links for Blogs and Tags pages within the content panel area
    • Implemented conditional rendering to show these links only when in the content panel
  3. User Authentication Features:

    • Integrated user avatar display for authenticated users
    • Implemented a dropdown menu accessible by clicking on the user avatar
    • Menu includes user information (name and email) and a sign-out option
  4. Improved User Experience:

    • Added a click-outside listener to automatically close the user menu when clicking elsewhere on the page
    • Enhanced the visual feedback for active navigation links

image

@mitkapanarin mitkapanarin linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 10:41pm

@edichoska edichoska changed the base branch from main to staging December 6, 2024 12:38
Copy link
Contributor

@edichoska edichoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitkapanarin Please clean up this PR. I know you were working on the Invite Member ticket for the admin-panel, and I can see you transferred all that code to this branch as well.
This branch and the ticket that corresponds to it should be only for content panel and the navigation.
Rerequest review when you have changed this. 🙏

@@ -6,7 +6,7 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
env:
BASE_URL: 'http://localhost:3000'
BASE_URL: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by this change. Why was this necessary?

@edichoska
Copy link
Contributor

@mitkapanarin should we close this PR, as I see you created a new one?

@mitkapanarin
Copy link
Author

mitkapanarin commented Dec 8, 2024 via email

@edichoska
Copy link
Contributor

Yes, I created a new branch and made all the changes there. Is that okay? Sent from Yahoo Mail for iPhone On Sunday, December 8, 2024, 4:33 PM, Emilija Dichoska @.> wrote: @mitkapanarin should we close this PR, as I see you created a new one? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

Yes, ofcourse. Just wanted to double check if I can close this PR.

@edichoska
Copy link
Contributor

Duplicate

@edichoska edichoska closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] Content Panel: Improvements in navigation
2 participants