-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Host rustdoc of master
on GitHub pages
#3126
Conversation
master
on GitHub pages
master
on GitHub pagesmaster
on GitHub pages
LGTM! I think the changes to the GitHub pages configuration will need to be made over here: https://github.com/libp2p/github-mgmt/blob/0e08ed66ddd586d3f31f98d1aa4cb54e3795737e/github/libp2p.yml#L3962 I got no idea what the correct config looks like. @galargh Can you help here? |
Sadly, terraform provider (and because of that - GitHub Management) doesn't support I made the required changes through the UI in this repo. You should be good to proceed. |
What is missing here? It should be ready to merge from my POV |
Not sure why CI is failing. Will need to take a look. |
Moving forward here. |
Docs page is fancy. Thanks @umgefahren. |
In case you want to draw more attention to it, referencing the page next to the already referenced libp2p docs in the main README.md would be a good idea. |
Description
This PR hosts the documentation of the current master branch on GitHub Pages. The URL should be: https://libp2p.github.io/rust-libp2p
I tested the configuration on my repo and it works. You can see the result under: https://umgefahren.github.io/rust-libp2p
Notes
This PR requires a change of settings in the pages tab. The screenshot below shows the correct configuration:
Links to any relevant issues
Solving #3125. Sorry for opening so many issues and then immediately providing PRs.
Open Questions
Is the community happy with this.