Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@clayui/table):LPD 42395 Add tooltips to table action buttons in Clay Table #5895

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

ilzamcmed
Copy link
Member

@ilzamcmed ilzamcmed commented Nov 19, 2024

Jira issue: https://liferay.atlassian.net/browse/LPD-42395

  • feat (@clayui/table): LPD-42395 Add tooltips to table action buttons in Clay Table
  • feat (@clayui/table): LPD-42395 Update snapshot

@ilzamcmed ilzamcmed changed the title LPD 42395 feat(@clayui/table):LPD 42395 Add tooltips to table action buttons in Clay Table Nov 19, 2024
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments in the case of the Cell component but it applies to other cases as well. Thanks @ilzamcmed!

packages/clay-core/src/table/Cell.tsx Outdated Show resolved Hide resolved
packages/clay-core/src/table/Cell.tsx Outdated Show resolved Hide resolved
packages/clay-core/src/table/Cell.tsx Outdated Show resolved Hide resolved
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit 356cb11 into liferay:master Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants