Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@clayui/table):LPD 42395 Add tooltips to table action buttons in Clay Table #5895

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat(@clayui/table):LPD 42395 Add tooltips to table action buttons in Clay Table #5895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2834a18
feat(@clayui/table): LPD-42395 Add tooltips to table action buttons i…
ilzamcmed Nov 19, 2024
09038db
feat(@clayui/table): LPD-42395 Update snapshot
ilzamcmed Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/clay-core/src/table/Cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ export const Cell = React.forwardRef<HTMLTableCellElement, Props>(
</Layout.ContentCol>
<Layout.ContentCol>
<button
aria-label={messages['sortDescription']}
className="component-action"
title={messages['sortDescription']}
type="button"
>
<Icon
Expand Down Expand Up @@ -286,7 +286,6 @@ export const Cell = React.forwardRef<HTMLTableCellElement, Props>(
{isExpandable && (
<Layout.ContentCol className="autofit-col-toggle">
<Button
aria-label={messages['expandable']}
borderless
displayType="secondary"
monospaced
Expand All @@ -299,6 +298,7 @@ export const Cell = React.forwardRef<HTMLTableCellElement, Props>(
}}
size="xs"
tabIndex={-1}
title={messages['expandable']}
>
<Icon
symbol={
Expand Down
1 change: 1 addition & 0 deletions packages/clay-core/src/table/Head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ function HeadInner<T extends Record<string, any>>(
borderless
displayType="secondary"
monospaced
title={messages['columnsVisibility']}
>
<Icon symbol="caret-bottom" />
</Button>
Expand Down
10 changes: 7 additions & 3 deletions packages/clay-core/src/table/__tests__/__snapshots__/BasicRendering.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ exports[`Table basic rendering render dynamic content 1`] = `
aria-haspopup="true"
aria-label="Manage Columns Visibility"
class="dropdown-toggle btn btn-monospaced btn-outline-borderless btn-outline-secondary"
title="Manage Columns Visibility"
type="button"
>
<svg
Expand Down Expand Up @@ -195,6 +196,7 @@ exports[`Table basic rendering render static content 1`] = `
aria-haspopup="true"
aria-label="Manage Columns Visibility"
class="dropdown-toggle btn btn-monospaced btn-outline-borderless btn-outline-secondary"
title="Manage Columns Visibility"
type="button"
>
<svg
Expand Down Expand Up @@ -350,8 +352,8 @@ exports[`Table basic rendering render with sort column 1`] = `
class="autofit-col"
>
<button
aria-label="sortable column"
class="component-action"
title="sortable column"
type="button"
>
<svg
Expand Down Expand Up @@ -395,8 +397,8 @@ exports[`Table basic rendering render with sort column 1`] = `
class="autofit-col"
>
<button
aria-label="sortable column"
class="component-action"
title="sortable column"
type="button"
>
<svg
Expand Down Expand Up @@ -424,6 +426,7 @@ exports[`Table basic rendering render with sort column 1`] = `
aria-haspopup="true"
aria-label="Manage Columns Visibility"
class="dropdown-toggle btn btn-monospaced btn-outline-borderless btn-outline-secondary"
title="Manage Columns Visibility"
type="button"
>
<svg
Expand Down Expand Up @@ -584,6 +587,7 @@ exports[`Table basic rendering render with treegrid 1`] = `
aria-haspopup="true"
aria-label="Manage Columns Visibility"
class="dropdown-toggle btn btn-monospaced btn-outline-borderless btn-outline-secondary"
title="Manage Columns Visibility"
type="button"
>
<svg
Expand Down Expand Up @@ -673,9 +677,9 @@ exports[`Table basic rendering render with treegrid 1`] = `
class="autofit-col-toggle autofit-col"
>
<button
aria-label="expandable"
class="btn btn-monospaced btn-outline-borderless btn-outline-secondary btn-xs"
tabindex="-1"
title="expandable"
type="button"
>
<svg
Expand Down
Loading