Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beat [5/4]: fix itests for blockbeat #9227

Open
wants to merge 27 commits into
base: yy-blockbeat-end
Choose a base branch
from
Open

Beat [5/4]: fix itests for blockbeat #9227

wants to merge 27 commits into from

Conversation

yyforyongyu
Copy link
Member

@yyforyongyu yyforyongyu commented Oct 28, 2024 •
edited
Loading

This PR is meant to fix all the itests that are failing due to the new behaviors introduced from blockbeat. There are still other non-blockbeat-related flakes, which are fixed in the final PR.

Major changes in this PR,

  • remove all the hacks used in the tests related to the sweeper
  • fix the tests to reflect the new blockbeat behavior
  • refactor the multi-hop tests to make them easier to be maintained - a lot of time was taken in the past to fix and maintain these tests (especially in the sweeper series), to make sure we could suffer less, these tests are now refactored to be more linear so it's easier to follow and update them in the future.
  • remove multiple redundant block mining.

@yyforyongyu yyforyongyu added itests Issues related to integration tests. size/mega large, significant context needed, over 1000 lines labels Oct 28, 2024
@yyforyongyu yyforyongyu self-assigned this Oct 28, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Oct 28, 2024
Merged
Merged
@yyforyongyu yyforyongyu force-pushed the yy-blockbeat-finalize branch from 0ab9846 to a5d0e99 Compare October 29, 2024 14:17
This was referenced Oct 29, 2024
Merged
Merged
@yyforyongyu yyforyongyu added this to the v0.19.0 milestone Oct 29, 2024
@ziggie1984 ziggie1984 self-requested a review November 5, 2024 12:15
@yyforyongyu yyforyongyu mentioned this pull request Nov 7, 2024
Merged
@yyforyongyu yyforyongyu force-pushed the yy-blockbeat-finalize branch 5 times, most recently from 6819393 to ac8ce82 Compare November 18, 2024 06:04
This was referenced Nov 18, 2024
Merged
Merged
@yyforyongyu yyforyongyu changed the base branch from yy-blockbeat-finalize to yy-blockbeat-end November 18, 2024 06:46
@yyforyongyu yyforyongyu force-pushed the yy-blockbeat-end branch 3 times, most recently from 96474de to c7747a2 Compare November 20, 2024 06:22
@yyforyongyu yyforyongyu force-pushed the yy-blockbeat-end branch 2 times, most recently from a4f226a to 9f740cc Compare November 21, 2024 14:45
@yyforyongyu
multi: optimize loggings around changes from blockbeat
1329187
@yyforyongyu
lntest+itest: fix testSweepCPFPAnchorOutgoingTimeout
e1c466b
@yyforyongyu
itest: fix testSweepCPFPAnchorIncomingTimeout
0b3a583
@yyforyongyu
itest: fix testSweepHTLCs
9bd944e
@yyforyongyu
itest: fix testSweepCommitOutputAndAnchor
809b196
@yyforyongyu
itest: fix testBumpForceCloseFee
9c28202
@yyforyongyu
itest: fix testPaymentSucceededHTLCRemoteSwept
7b55f27
@yyforyongyu
lntest+itest: start flattening the multi-hop tests
494ea82 
Starting from this commit, we begin the process of flattening the
multi-hop itests to make them easier to be maintained. The tests are
refactored into their own test cases, with each test focusing on testing
one channel type. This is necessary to save effort for future
development.

These tests are also updated to reflect the new `blockbeat` behavior.
@yyforyongyu
itest: simplify and flatten testMultiHopReceiverChainClaim
40e845f
@yyforyongyu
lntest+itest: flatten testMultiHopLocalForceCloseOnChainHtlcTimeout
cdd43a6
@yyforyongyu
lntest+itest: flatten testMultiHopRemoteForceCloseOnChainHtlcTimeout
d5806e5
@yyforyongyu
itest: flatten testMultiHopHtlcLocalChainClaim
9116774
@yyforyongyu
itest: flatten testMultiHopHtlcRemoteChainClaim
abd6601
@yyforyongyu
itest: flatten testMultiHopHtlcAggregation
bcd86a8
@yyforyongyu
itest: flatten testHtlcTimeoutResolverExtractPreimageLocal
5bc558e 
This commit simplfies the test since we only test the preimage
extraction logic in the htlc timeout resolver, there's no need to test
it for all different channel types as the resolver is made to be
oblivious about them.
@yyforyongyu
itest: flatten testHtlcTimeoutResolverExtractPreimageRemote
f2fc527 
Also remove unused code.
@yyforyongyu
itest: rename file to reflect the tests
b688252
@yyforyongyu
itest: remove unnecessary force close
0f69894
@yyforyongyu
itest: remove redundant block mining in testFailingChannel
47412b5
@yyforyongyu
itest: remove redunant block mining in `testChannelFundingWithUnstabl…
4c40544 
…eUtxos`
@yyforyongyu
itest: remove redudant block in testPsbtChanFundingWithUnstableUtxos
fd54b66
@yyforyongyu
itest: remove redundant blocks in channel backup tests
56dfad4
@yyforyongyu
itest+lntest: fix channel force close test
4022007 
Also flatten the tests to make them easier to be maintained.
@yyforyongyu
itest: flatten and fix testWatchtower
5e2caeb
@yyforyongyu
itest: remove redundant block in multiple tests
2825ce5
@yyforyongyu
itest: assert payment status after sending
61141c1
@yyforyongyu
lntest+itest: remove the usage of ht.AssertActiveHtlcs
eabf0a5 
The method `AssertActiveHtlcs` is now removed due to it's easy to be
misused. To assert a given htlc, use `AssertOutgoingHTLCActive` and
`AssertIncomingHTLCActive` instead for ensuring the HTLC exists in the
right direction. Although often the case `AssertNumActiveHtlcs` would be
enough as it implicitly checks the forwarding behavior for an
intermediate node by asserting there are always num_payment*2 HTLCs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziggie1984 ziggie1984 Awaiting requested review from ziggie1984

Assignees

@yyforyongyu yyforyongyu

Labels
itests Issues related to integration tests. size/mega large, significant context needed, over 1000 lines
Projects
lnd v0.19
Status: No status
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
1 participant
@yyforyongyu