contractcourt: include custom records on replayed htlc #9357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
When notifying the invoice registry for an exit hop htlc we also want to include its custom records. The channelLink, the other caller of this method, already populates this field. So we make sure the contest resolver does so too.
GeorgeTsagk
force-pushed
the
onchain-htlc-replay-wire-records
branch
from
2c54b97 to
3f7a40e
Compare
|
Changed base to |
guggero
reviewed
Dec 13, 2024
| @@ -308,7 +308,8 @@ func (h *htlcIncomingContestResolver) Resolve( | |||
|
|
|||
| resolution, err := h.Registry.NotifyExitHopHtlc( | |||
| h.htlc.RHash, h.htlc.Amt, h.htlcExpiry, currentHeight, | |||
| circuitKey, hodlQueue.ChanIn(), nil, payload, | |||
| circuitKey, hodlQueue.ChanIn(), h.htlc.CustomRecords, | |||
There was a problem hiding this comment.
Hmm, I could swear I already had this diff in some version... But then didn't include it for some reason. Perhaps because it ended up working in a different way? Or because it ended up breaking something else? I guess we'll see about the latter in the itests.
guggero
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When notifying the invoice registry for an exit hop htlc we also want to
include its custom records. The channelLink, the other caller of this
method, already populates this field. So we make sure the contest
resolver does so too.