Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some HiP-CT docs #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add some HiP-CT docs #18

wants to merge 3 commits into from

Conversation

dstansby
Copy link
Member

This adds some docs on the HiP-CT data, including registrations, as requested by @kabilar. cc @ucbpclw

docs/data/hipct.md Outdated Show resolved Hide resolved
docs/data/hipct.md Outdated Show resolved Hide resolved
docs/data/hipct.md Outdated Show resolved Hide resolved
docs/test.md Outdated Show resolved Hide resolved
docs/data/hipct.md Outdated Show resolved Hide resolved
Comment on lines +12 to +13
Datasets have the name `sub-<donor>_sample-<sample name>_chunk<chunk number>_PC.ome.zarr`.
The chunk number is set to `yyxx`, where yy is the resolution of the scan in micrometers, and xx is a scan number that is unique between datasets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use the acq entity for the resolution. The chunk entity could be used for different fields of view in the same sample. If the same field of view is acquired multiple times then perhaps the ses entity should be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good - we could do acq-overview and acq-zoom for the low/high resolution scans. I don't think we have the same field of view multiple times, and if we do it won't be exactly the same scan/field of view so I don't think we need to use ses.

I'll take a look into renaming our datasets to use acq.

Copy link
Member

@kabilar kabilar Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstansby. Sounds great.

So for example the file sub-I58_sample-blockIC2_chunk-201_PC.ome.zarr would be renamed to sub-I58_sample-blockIC2_acq-zoom_chunk-01_PC.ome.zarr and sub-I58_sample-blockIC2_chunk-401_PC.ome.zarr would be renamed to sub-I58_sample-blockIC2_acq-zoom_chunk-02_PC.ome.zarr?

Since you are renaming files should we change the modality suffix? If I am not mistaken, I believe that PC is now going to be XPCT.

Copy link
Member Author

@dstansby dstansby Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new datasets would be called:

sub-I58_sample-blockIC2_acq-zoom_chunk-01_PC.ome.zarr
sub-I58_sample-blockIC2_acq-overview_PC.ome.zarr

For the overviews, we only have one per sample, so I think we don't want to use chunk for these datasets? If we end up more than one overview per sample (e.g., taken at different times or with different resolutions) we could then make the acq label more specific for each dataset (e.g., acq-overview2025 in the hypothetical instance that we do another one next year)

Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dstansby. This is great. I have a few suggestions above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants