Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some HiP-CT docs #18
base: main
Are you sure you want to change the base?
Add some HiP-CT docs #18
Changes from 1 commit
a67062f
33d30d4
dce63b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should use the acq entity for the resolution. The chunk entity could be used for different fields of view in the same sample. If the same field of view is acquired multiple times then perhaps the ses entity should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good - we could do
acq-overview
andacq-zoom
for the low/high resolution scans. I don't think we have the same field of view multiple times, and if we do it won't be exactly the same scan/field of view so I don't think we need to useses
.I'll take a look into renaming our datasets to use
acq
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dstansby. Sounds great.
So for example the file
sub-I58_sample-blockIC2_chunk-201_PC.ome.zarr
would be renamed tosub-I58_sample-blockIC2_acq-zoom_chunk-01_PC.ome.zarr
andsub-I58_sample-blockIC2_chunk-401_PC.ome.zarr
would be renamed tosub-I58_sample-blockIC2_acq-zoom_chunk-02_PC.ome.zarr
?Since you are renaming files should we change the modality suffix? If I am not mistaken, I believe that
PC
is now going to beXPCT
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new datasets would be called:
sub-I58_sample-blockIC2_acq-zoom_chunk-01_PC.ome.zarr
sub-I58_sample-blockIC2_acq-overview_PC.ome.zarr
For the overviews, we only have one per sample, so I think we don't want to use
chunk
for these datasets? If we end up more than one overview per sample (e.g., taken at different times or with different resolutions) we could then make theacq
label more specific for each dataset (e.g.,acq-overview2025
in the hypothetical instance that we do another one next year)Check failure on line 16 in docs/data/hipct.md
GitHub Actions / Check for spelling errors