Add --policy-config argument to create-genesis-config #3414
+123
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-ds
force-pushed
the
02-25-add_--policy-config_argument_to_create-genesis-config
branch
from
cc46027 to
975a240
Compare
afck
reviewed
Feb 26, 2025
|
|
||
| Default value: `0` | ||
| * `--read-operation-price <READ_OPERATION_PRICE>` — Set the price per read operation | ||
| Possible values: `default`, `only-fuel`, `fuel-and-block`, `all-categories`, `devnet` |
There was a problem hiding this comment.
I'm not sure we need all these, and I don't think the names should be user-visible like this. I think we should only have two user-visible ones:
testnet(renamed fromdevnet), andno-fees(renamed fromdefault, where everything is zero and limits areMAX).
The other two are, I think, only used in tests, and should be feature-gated?
deuszx
reviewed
Feb 26, 2025
| /// Set the base price for creating a block. | ||
| #[arg(long, default_value = "0")] | ||
| block_price: Amount, | ||
| #[arg(long)] |
There was a problem hiding this comment.
I think there's an option in clap to mark arguments mutually exclusive - i.e. that one doesn't have to be provided if another one is (here path to the config file).
Unless we want to allow for overwriting the config file with CLI args but if we do I'd suggest adding that explicitly in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we pass everything manually, but there's already a config that can make this easier
Proposal
User the policy config instead
Test Plan
CI
Release Plan