-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --policy-config argument to create-genesis-config #3414
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -640,49 +640,54 @@ pub enum ClientCommand { | |
/// Number of initial (aka "root") chains to create in addition to the admin chain. | ||
num_other_initial_chains: u32, | ||
|
||
/// Configure the resource control policy (notably fees) according to pre-defined | ||
/// settings. | ||
#[arg(long, default_value = "default")] | ||
policy_config: ResourceControlPolicyConfig, | ||
|
||
/// Set the base price for creating a block. | ||
#[arg(long, default_value = "0")] | ||
block_price: Amount, | ||
#[arg(long)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's an option in Unless we want to allow for overwriting the config file with CLI args but if we do I'd suggest adding that explicitly in the comments. |
||
block_price: Option<Amount>, | ||
|
||
/// Set the price per unit of fuel. | ||
#[arg(long, default_value = "0")] | ||
fuel_unit_price: Amount, | ||
#[arg(long)] | ||
fuel_unit_price: Option<Amount>, | ||
|
||
/// Set the price per read operation. | ||
#[arg(long, default_value = "0")] | ||
read_operation_price: Amount, | ||
#[arg(long)] | ||
read_operation_price: Option<Amount>, | ||
|
||
/// Set the price per write operation. | ||
#[arg(long, default_value = "0")] | ||
write_operation_price: Amount, | ||
#[arg(long)] | ||
write_operation_price: Option<Amount>, | ||
|
||
/// Set the price per byte read. | ||
#[arg(long, default_value = "0")] | ||
byte_read_price: Amount, | ||
#[arg(long)] | ||
byte_read_price: Option<Amount>, | ||
|
||
/// Set the price per byte written. | ||
#[arg(long, default_value = "0")] | ||
byte_written_price: Amount, | ||
#[arg(long)] | ||
byte_written_price: Option<Amount>, | ||
|
||
/// Set the price per byte stored. | ||
#[arg(long, default_value = "0")] | ||
byte_stored_price: Amount, | ||
#[arg(long)] | ||
byte_stored_price: Option<Amount>, | ||
|
||
/// Set the base price of sending an operation from a block.. | ||
#[arg(long, default_value = "0")] | ||
operation_price: Amount, | ||
#[arg(long)] | ||
operation_price: Option<Amount>, | ||
|
||
/// Set the additional price for each byte in the argument of a user operation. | ||
#[arg(long, default_value = "0")] | ||
operation_byte_price: Amount, | ||
#[arg(long)] | ||
operation_byte_price: Option<Amount>, | ||
|
||
/// Set the base price of sending a message from a block.. | ||
#[arg(long, default_value = "0")] | ||
message_price: Amount, | ||
#[arg(long)] | ||
message_price: Option<Amount>, | ||
|
||
/// Set the additional price for each byte in the argument of a user message. | ||
#[arg(long, default_value = "0")] | ||
message_byte_price: Amount, | ||
#[arg(long)] | ||
message_byte_price: Option<Amount>, | ||
|
||
/// Set the maximum amount of fuel per block. | ||
#[arg(long)] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need all these, and I don't think the names should be user-visible like this. I think we should only have two user-visible ones:
testnet
(renamed fromdevnet
), andno-fees
(renamed fromdefault
, where everything is zero and limits areMAX
).The other two are, I think, only used in tests, and should be feature-gated?