[RTG] Add ElaborationPass #7876
Open
+784
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
force-pushed
the
maerhart-rtg-elaboration-pass
branch
from
36dfd4c
to
2633cab
Compare
youngar
reviewed
Nov 26, 2024
Comment on lines
+515
to
+516
| newTest.setSymName(test.getSymName().str() + "_" + | ||
| target.getSymName().str()); |
There was a problem hiding this comment.
Could this cause a name collision? You can use the SymbolTable to help generate unique symbols
Comment on lines
503
to
505
| // If the test requries nothing from a target, we can always run it. | ||
| if (test.getTarget().getEntryTypes().empty()) | ||
| continue; |
There was a problem hiding this comment.
So if a test does not have any requirements we won't run it on each target, just once in general?
There was a problem hiding this comment.
There are two things to consider:
- The unelaborated test is the same for all targets, so do we want to randomize it once for each target or randomize it once and use that for each target? If the latter, then we don't have to copy it. But I guess the earlier approach would be the more consistent one, right?
- Currently I assume that all tests for all targets will be run on the same system because there is no way to distinguish them after this pass. If we want to have targets for different systems in the same MLIR file, we'd need some scoping, add the target that the test specialized for as an attribute, or some other way to distinguish them. As long as we don't do that, we don't need to duplicate a test that has the same content.
I guess I will change it to be copied and independently randomized for each target, but leave point 2 for a future PR.
There was a problem hiding this comment.
I don't really know whats best, what you had originally is probably good! We can revisit these points in the future easily enough.
maerhart
force-pushed
the
maerhart-rtg-test-and-target
branch
3 times, most recently
from
506937f
to
14a434c
Compare
maerhart
force-pushed
the
maerhart-rtg-elaboration-pass
branch
from
2633cab
to
b89ad7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pass that lowers the random parts of RTG IR.