Make llvm::telemetry::Manager::preDispatch protected. #127114
Merged
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e called directly by users
labath
approved these changes
Feb 14, 2025
| @@ -150,6 +146,11 @@ class Manager { | |||
| // Register a Destination. | |||
| void addDestination(std::unique_ptr<Destination> Destination); | |||
|
|
|||
| protected: | |||
| // Optional callback for subclasses to perform additional tasks before | |||
There was a problem hiding this comment.
If it's optional, maybe it should have a default implementation (doing nothing, successfully)?
There was a problem hiding this comment.
+1 this makes sense to me.
There was a problem hiding this comment.
done - added the empty impl for preDispatch
Okay, I've read #126588 (comment) now. I can live with that, though I don't find that example particularly compelling as parallelism could be achieved by handing the telemetry entry to a different thread from inside Destination::receiveEntry (which is also virtual). |
|
BTW, I just noticed that Telemetry.cpp is missing a licence header. |
jh7370
approved these changes
Feb 14, 2025
| @@ -150,6 +146,11 @@ class Manager { | |||
| // Register a Destination. | |||
| void addDestination(std::unique_ptr<Destination> Destination); | |||
|
|
|||
| protected: | |||
| // Optional callback for subclasses to perform additional tasks before | |||
There was a problem hiding this comment.
+1 this makes sense to me.
done! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/2043 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/6674 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/17176 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/54/builds/6503 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/6550 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/8731 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/10919 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/8246 Here is the relevant piece of the build log for the reference |
kazutakahirata
added a commit
that referenced
this pull request
Feb 15, 2025
|
@oontvoo I've reverted your PR. I'm happy to test your new version. By the way, I've locally reproduced the failure with |
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 15, 2025
…ed. (#127114)" This reverts commit f7a2d70. Multiple buildbot failures have been reported. See: llvm/llvm-project#127114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was meant to be overriden by subclasses only.
It should not be called directly by users