Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Switch Link, Heading and Text to v3 design tokens #DS-1451 #1622

Merged
merged 3 commits into from
Sep 19, 2024
Merged

BREAKING CHANGE: Switch Link, Heading and Text to v3 design tokens #DS-1451 #1622

merged 3 commits into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 7, 2024
@github-actions github-actions bot added the BC Breaking change label Sep 7, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 73ff4ca
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ebef2cecea1100082b4877
😎 Deploy Preview https://deploy-preview-1622--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 7, 2024 •
edited
Loading

Coverage Status

coverage: 78.654% (-0.003%) from 78.657%
when pulling 73ff4ca on bc/v3-link-heading-text
into c09db59 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 1026e5e to 9e0cf35 Compare September 11, 2024 09:22
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 9db83f9 to 4289f81 Compare September 11, 2024 09:41
@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 73ff4ca
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ebef2ca8afb50008228733
😎 Deploy Preview https://deploy-preview-1622--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 9e0cf35 to 2c04230 Compare September 11, 2024 11:52
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 4289f81 to cce943f Compare September 11, 2024 11:53
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10811064032/artifacts/1919243586

literat
literat approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from cce943f to 95501e8 Compare September 11, 2024 14:51
@crishpeen crishpeen mentioned this pull request Sep 12, 2024
Merged
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 95501e8 to 8332923 Compare September 12, 2024 14:43
adamkudrna
adamkudrna requested changes Sep 12, 2024
View reviewed changes
packages/web-react/src/components/Heading/README.md Outdated Show resolved Hide resolved
packages/web-react/src/types/heading.ts Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Heading/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Heading/__tests__/__fixtures__/headingDefault.twig Outdated Show resolved Hide resolved
packages/web/src/scss/helpers/links/_links.scss Show resolved Hide resolved
packages/web-react/src/components/Heading/useHeadingStyleProps.ts Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Text/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/helpers/typography/index.html Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_EmptyState/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_EmptyState/index.html Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 8332923 to 6e4143a Compare September 17, 2024 07:36
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 6e4143a to 1e555e2 Compare September 17, 2024 12:30
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10903077598/artifacts/1942568963

@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch 2 times, most recently from fa7142d to 3015abd Compare September 17, 2024 14:46
adamkudrna
adamkudrna requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text components look good, but the EmptyState requires attention so it's visually aligned with the latest Figma design.

packages/web-react/src/components/Heading/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Heading/README.md Show resolved Hide resolved
packages/web-twig/src/Resources/components/Heading/README.md Show resolved Hide resolved
packages/web-react/src/components/Text/README.md Show resolved Hide resolved
packages/web/src/scss/helpers/links/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_dictionaries.scss Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_EmptyState/demo/EmptyStateDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_EmptyState/demo/EmptyStateDefault.tsx Show resolved Hide resolved
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 31283eb to 1155973 Compare September 19, 2024 07:29
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10936431109/artifacts/1951735394

@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 1155973 to 67b1d14 Compare September 19, 2024 08:02
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10936896496/artifacts/1951862910

@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 67b1d14 to 8a1c342 Compare September 19, 2024 08:25
@crishpeen
BREAKING CHANGE(web): Switch Link and typography helpers to v3 design…
aa22756 
… tokens #DS-1451
@crishpeen
BREAKING CHANGE(web-react): Switch Link, Heading and Text to v3 desig…
ff2eb05 
…n tokens #DS-1451

Remove inverted Link variant and introduce emphasis in Heading.
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 8a1c342 to 11cf542 Compare September 19, 2024 09:25
@crishpeen
BREAKING CHANGE(web-twig): Switch Link, Heading and Text to v3 design…
73ff4ca 
… tokens #DS-1451

Remove inverted Link variant and introduce emphasis in Heading.
@crishpeen crishpeen force-pushed the bc/v3-link-heading-text branch from 11cf542 to 73ff4ca Compare September 19, 2024 09:30
@crishpeen crishpeen merged commit 2d42419 into integration/BC-v3-design-tokens Sep 19, 2024
26 checks passed
@crishpeen crishpeen deleted the bc/v3-link-heading-text branch September 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@crishpeen crishpeen

Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @adamkudrna