Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/theme switcher in demo #1676

Merged

Conversation

adamkudrna
Copy link
Contributor

Description

Additional context

obrazek
obrazek

Issue reference

https://jira.almacareer.tech/browse/DS-1479

@adamkudrna adamkudrna requested a review from a team as a code owner October 1, 2024 15:00
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 1, 2024
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5472c52
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66fe9563e23a9d00086f1405

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5472c52
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66fe956348ddc40008908ab9
😎 Deploy Preview https://deploy-preview-1676--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 1, 2024

Coverage Status

coverage: 78.791% (+12.4%) from 66.382%
when pulling 5472c52 on docs/theme-switcher-in-demo
into 40ac97b on integration/BC-v3-design-tokens.

apps/demo/config/vite/app.ts Show resolved Hide resolved
apps/demo/config/vite/app.ts Outdated Show resolved Hide resolved
@crishpeen
Copy link
Member

We might have a bug there. On first load the select gets weird hover background. When I change the value, it does not happen anymore.

@adamkudrna adamkudrna force-pushed the docs/redesign-twig-demo-app branch from 9d6c2f8 to 95cbb8a Compare October 3, 2024 09:29
@adamkudrna adamkudrna force-pushed the docs/redesign-twig-demo-app branch from 95cbb8a to 0172f1a Compare October 3, 2024 09:34
Base automatically changed from docs/redesign-twig-demo-app to integration/BC-v3-design-tokens October 3, 2024 10:56
@adamkudrna adamkudrna force-pushed the docs/theme-switcher-in-demo branch from 5687de3 to 813201a Compare October 3, 2024 12:26
@adamkudrna adamkudrna force-pushed the docs/theme-switcher-in-demo branch from 813201a to 5472c52 Compare October 3, 2024 13:00
@adamkudrna adamkudrna merged commit e8eaa38 into integration/BC-v3-design-tokens Oct 3, 2024
14 checks passed
@adamkudrna adamkudrna deleted the docs/theme-switcher-in-demo branch October 3, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants