Show type of alert in the alert banner #376
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #345
What does this change?
Provides a default space in the template to show the output of type of alert. This uses a value from manage display, so it will only show if configured to do so. This will be the default in new installs only.
How to test
How can we measure success?
Fixes accesbility issue identified in #345 , allbeit in this case without the role as its just plain text.
Have we considered potential risks?
This might not be the right solution, it won't effect current installs, it won't override existing themes.
However in this case it's more about providing an accessible default, as the issue identified in #345 is likley the themes responsibility?
Images
Accessibility