Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type of alert in the alert banner #376

Draft
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

andybroomfield
Copy link
Contributor

@andybroomfield andybroomfield commented Sep 9, 2024

Fix #345

  • Support showing type of alert in the banner template
  • Show the type of alert in the banner by default

What does this change?

Provides a default space in the template to show the output of type of alert. This uses a value from manage display, so it will only show if configured to do so. This will be the default in new installs only.

How to test

  1. To fresh install
  2. Choose a non localgov_base derived theme (localgov_base overrides the template).
  3. Create an alert banner of each type
  4. View alert banner, which should now show the type of alert.

How can we measure success?

Fixes accesbility issue identified in #345 , allbeit in this case without the role as its just plain text.

Have we considered potential risks?

This might not be the right solution, it won't effect current installs, it won't override existing themes.
However in this case it's more about providing an accessible default, as the issue identified in #345 is likley the themes responsibility?

Images

Screenshot 2024-09-09 at 9 17 18 PM

Accessibility

@andybroomfield
Copy link
Contributor Author

Are the names:

  • Announcement
  • Minor alert
  • Emergency
  • Death of a notable person
    Suitable for public display? They where only intended for internal use.

@andybroomfield andybroomfield mentioned this pull request Sep 13, 2024
1 task
Base automatically changed from 1.8.x to 1.x October 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant