Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add drupal 11 workflow testing #19

Draft
wants to merge 42 commits into
base: 1.x
Choose a base branch
from

Conversation

millnut
Copy link
Member

@millnut millnut commented Dec 12, 2024

What does this change?

Update the workflow testing to support D11. This means we test

  • Drupal 10
    • localgov project 3.x (patched for D10 and D11)
    • PHP 8.1, 8.2, 8.3, 8.4
  • Drupal 11
    • localgov project 3.x (patched for D10 and D11)
    • PHP 8.3, 8.4

Coding standards and PHPstan we can update once Drupal 10 support for PHP 8.4 is released, due in Drupal 10.4.x

@millnut
Copy link
Member Author

millnut commented Dec 12, 2024

Added an example here @stephen-cox https://github.com/localgovdrupal/localgov_alert_banner/actions/runs/12301561123/job/34332421512

For the project we'd need 3.x for D10 and 4.x for D11 due to package differences and PHP version support.

localgov profile we could get away with having the 3.x branch support both Drupal 10 and 11.

After that, I can update the workflow.

composer --working-dir=./html require --no-install localgovdrupal/localgov:${{ matrix.localgov-version }}-dev
composer --working-dir=./html require --no-install drupal/core-recommended:${{ matrix.drupal-version }} drupal/core-composer-scaffold:${{ matrix.drupal-version }} drupal/core-project-message:${{ matrix.drupal-version }} drupal/core-dev:${{ matrix.drupal-version }}
composer --working-dir=./html install

- name: Create LocalGov Drupal 11 project
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary workaround until the localgov profile supports D11

- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- first test run of d10 and d11 support
- added phpunit testing
@millnut
Copy link
Member Author

millnut commented Dec 25, 2024

@stephen-cox I had a little break between cooking Christmas dinner, so I've done some more work here and both D10 and D11 install and run without failures https://github.com/localgovdrupal/localgov_alert_banner/actions/runs/12483172646.

I've created a bunch of in-progress PRs for D11 which you'll see in the composer require.

The only failures on this module are from the PHPUnit side related to PHP 8.4 and a library drupal/diff uses, which we use in localgov_workflows so it must trigger on the test setup and are unrelated to this actual module.

There are still some other contrib modules that do not yet have Drupal 11 compliant releases e.g. image widget crop, font awesome, etc...

Update: I've added a patch to the D11 support branch in the project to fix the PHP 8.4 errors, it's on my repo now but I've submitted a PR upstream as well (caxy/php-htmldiff#130) but we are showing green now (apart from eslint and stylelint)

@millnut millnut changed the title feat: add drupal 11 workflow testing [WIP] feat: add drupal 11 workflow testing Dec 25, 2024
- added additional composer aliases
- added additional composer aliases
- added additional composer aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants