Enable ratified bitmanip extensions for Rust demos #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using the (long-term) unstable `build-std` feature which requires the nightly compiler.
|
Target json is unstable, I would prefer if we use |
|
Thanks, that is a lot simpler. FYI I think it relies on |
Ibex supports a few more bitmanip extensions but they're not supported in upstream LLVM / Rust.
|
I think it should still work without |
nbdd0121
approved these changes
Aug 23, 2024
|
FYI I submitted this to Tock as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think bitmanip is important for the demos, just thought it was interesting that you can enable them.
Happy if this doesn't get merged, but someone can use this as a reference if they need it elsewhere.