Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ERC20Extended): only emit Approval on approve #14

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix(ERC20Extended): only emit Approval on approve #14

merged 1 commit into from
Feb 14, 2024

Conversation

PierrickGT
Copy link
Member

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

LCOV of commit 6beccc8 during Forge Coverage #54

Summary coverage rate:
  lines......: 94.6% (123 of 130 lines)
  functions..: 93.9% (46 of 49 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  src/ERC20Extended.sol        |94.7%     19| 100%     7|    -      0

@PierrickGT PierrickGT merged commit 3076d87 into main Feb 14, 2024
2 checks passed
@PierrickGT PierrickGT deleted the fix/WEB3-734-events-emission branch February 14, 2024 21:37
@PierrickGT PierrickGT mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toninorair toninorair toninorair approved these changes

@deluca-mike deluca-mike Awaiting requested review from deluca-mike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrickGT @toninorair