-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homework Pull Request #1
Open
madmatvey
wants to merge
11
commits into
main
Choose a base branch
from
homework_branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmatvey
force-pushed
the
homework_branch
branch
10 times, most recently
from
May 17, 2024 11:15
0a74ddf
to
858171b
Compare
madmatvey
force-pushed
the
homework_branch
branch
11 times, most recently
from
May 17, 2024 12:53
14362af
to
42e7e3e
Compare
madmatvey
force-pushed
the
homework_branch
branch
8 times, most recently
from
May 17, 2024 13:58
3aa7541
to
508e70f
Compare
madmatvey
force-pushed
the
homework_branch
branch
from
May 17, 2024 14:00
508e70f
to
1b57323
Compare
madmatvey
force-pushed
the
homework_branch
branch
from
May 17, 2024 14:11
89fb1b4
to
57a8c93
Compare
madmatvey
force-pushed
the
homework_branch
branch
from
May 17, 2024 14:29
06c614d
to
1aa2aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Alan and Pipeline CRM team,
I am thrilled to submit my completed Ruby on Rails & React homework assignment. This project has been an exciting challenge, and I am grateful for the opportunity to showcase my skills and expertise.
Throughout this assignment, I have focused on demonstrating my ability to resolve issues and implement new functionality in a scalable and simple manner, while adhering to best practices. I have carefully addressed each user story, striving to showcase my strengths and areas for growth.
In addressing the frontend issues, I have ensured that data is fetched correctly, filters are properly sent, and requests are handled efficiently to prevent unnecessary calls. On the backend, I have optimized database performance, applied filters effectively, and ensured that the application returns data promptly.
Moreover, I have taken significant steps to enhance the confidence in the current functionality and ability to deploy additional changes. I have implemented automated tests to ensure that new changes do not introduce regressions and have improved error handling to increase robustness.
I believe that my approach to this assignment reflects my commitment to delivering high-quality, maintainable code. I am eager to discuss my solutions in further detail and explore how my skills and experience align with the needs of your team.
Thank you for considering my application. I am looking forward to the possibility of advancing to the next stage of the interview process.
Warm regards,
Eugene Leontev