Publish as AoT #967

martincostello · 2023-11-25T15:03:19Z

Add verification tests of the output JSON.
Remove Application Insights as it is not AoT-compatible.
Use System.Text.Json for serialization instead of Newtonsoft.Json to support AoT.
Use invariant globalization and remove ICU package.
Enable publishing the Lambda for AoT.
Remove unused/duplicate custom JsonSerializerContext.
Add more end-to-end tests.

codecov · 2023-11-25T15:05:14Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e9095df) 96.65% compared to head (fc60961) 96.72%.

Files	Patch %	Lines
...Travel.Skill/Models/CustomStringEnumConverter`1.cs	62.50%	0 Missing and 3 partials ⚠️
...ondonTravel.Skill/Models/MixedDateTimeConverter.cs	71.42%	1 Missing and 1 partial ⚠️
src/LondonTravel.Skill/SkillResponseExtensions.cs	92.30%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   96.65%   96.72%   +0.06%     
==========================================
  Files          23       45      +22     
  Lines         479      641     +162     
  Branches       54       71      +17     
==========================================
+ Hits          463      620     +157     
- Misses          5        7       +2     
- Partials       11       14       +3

Flag	Coverage Δ
linux	`95.94% <96.39%> (+0.32%)`	⬆️
macos	`96.72% <96.39%> (+0.06%)`	⬆️
windows	`96.72% <96.39%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

martincostello · 2023-11-25T15:18:25Z

/deploy

martincostello · 2023-11-25T15:19:11Z

/deploy dev

github-actions · 2023-11-25T15:19:26Z

🧪 Tests for deployment to dev failed ❌

martincostello · 2023-11-25T15:32:14Z

/deploy dev

github-actions · 2023-11-25T15:32:34Z

🧪 Tests for deployment to dev passed ✅

martincostello · 2023-11-25T16:43:02Z

/deploy dev

martincostello · 2023-11-26T08:43:32Z

/deploy dev

github-actions · 2023-11-26T08:43:53Z

🧪 Tests for deployment to dev passed ✅

martincostello · 2023-11-26T08:52:55Z

/deploy dev

github-actions · 2023-11-26T08:53:10Z

🧪 Tests for deployment to dev passed ✅

martincostello · 2023-11-26T09:03:57Z

/deploy dev

github-actions · 2023-11-26T09:04:14Z

🧪 Tests for deployment to dev passed ✅

martincostello · 2023-11-26T10:35:49Z

/deploy dev

github-actions · 2023-11-26T10:36:06Z

🧪 Tests for deployment to dev passed ✅

martincostello · 2023-11-26T11:40:38Z

/deploy dev

github-actions · 2023-11-26T11:40:55Z

🧪 Tests for deployment to dev passed ✅

Add verification tests of the output JSON.

Remove ApplicationInsights as it is not AoT-compatible (and I never look at the data anyway).

- Use System.Text.Json for serialization instead of Newtonsoft.Json to support AoT. - Remove unused/duplicate custom `JsonSerializerContext`. - Add more end-to-end tests.

Enable publishing the Lambda for AoT.

Harden `SkillRequestExtensions` against null properties on the request and make it easier to debug.

Add missing brace.

Increase code coverage for ending a session.

Sort the properties.

Save some lines.

Until there's a GitHub Actions Linux runner with arm64 support, need to switch back to x64 as it is not possible to compile AoT for arm64 on an x64 Linux image.

Include the ICU libraries for linux-x64.

Make the type non-abstract to see if it fixes `NotSupportedException` when attempting to deserialize the payload.

Remove polymorphism as it is not supported when the type discriminator is not the first property in the JSON document. See dotnet/runtime#72604.

Use invariant globalisation and remove Microsoft.ICU.ICU4C.Runtime to reduce the AoT deployment size.

martincostello · 2023-11-26T17:00:57Z

/deploy dev

github-actions · 2023-11-26T17:01:14Z

🧪 Tests for deployment to dev passed ✅

Reduce memory required to 128MB (the minimum) to see if enabling AoT allows that to work.

martincostello · 2023-11-26T17:07:58Z

/deploy dev

github-actions · 2023-11-26T17:08:15Z

🧪 Tests for deployment to dev failed ❌

Increase TfL API timeout to 7.5 seconds.

martincostello · 2023-11-26T17:27:19Z

/deploy dev

github-actions · 2023-11-26T17:27:35Z

🧪 Tests for deployment to dev passed ✅

Compare the time to the same code with 128MB.

martincostello · 2023-11-26T17:42:06Z

/deploy dev

github-actions · 2023-11-26T17:42:22Z

🧪 Tests for deployment to dev passed ✅

Remove the verification tests now the JSON serialization migration is complete.

martincostello · 2023-11-27T08:55:42Z

Before AoT on arm64:

Published size: 123MB; 240 files

REPORT
Duration: 3092.87 ms
Billed Duration: 3817 ms
Memory Size: 192 MB
Max Memory Used: 89 MB
Init Duration: 723.62 ms

After AoT on x86_64:

Published size: 39.1MB; 4 files
Executable size: 13.4MB

REPORT
Duration: 219.74 ms
Billed Duration: 350 ms
Memory Size: 192 MB
Max Memory Used: 31 MB
Init Duration: 129.42 ms

TL;DR:

Duration: -93%
Billed Duration: -91%
Memory Size: -
Max Memory Used: -65%
Init Duration: -82%

Published size: -68%; -236 files

martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Nov 25, 2023

martincostello force-pushed the publish-aot branch from 32689c7 to 26f74e9 Compare November 25, 2023 16:35

martincostello force-pushed the publish-aot branch from e8035e8 to 0d7989e Compare November 26, 2023 11:34

martincostello added 8 commits November 26, 2023 16:40

Add verification tests

b2d297d

Add verification tests of the output JSON.

Remove ApplicationInsights

ed5fdae

Remove ApplicationInsights as it is not AoT-compatible (and I never look at the data anyway).

Remove Newtonsoft.Json

43aa257

- Use System.Text.Json for serialization instead of Newtonsoft.Json to support AoT. - Remove unused/duplicate custom `JsonSerializerContext`. - Add more end-to-end tests.

Publish AoT

a7a81b1

Enable publishing the Lambda for AoT.

Harden SkillRequestExtensions

70d46b2

Harden `SkillRequestExtensions` against null properties on the request and make it easier to debug.

Fix compilation

0d8a649

Add missing brace.

Increase coverage

2c7dd78

Increase code coverage for ending a session.

Sort properties

3ddfb45

Sort the properties.

martincostello added 6 commits November 26, 2023 16:49

Use expression body

12acd62

Save some lines.

Switch to x64

a5f6aed

Until there's a GitHub Actions Linux runner with arm64 support, need to switch back to x64 as it is not possible to compile AoT for arm64 on an x64 Linux image.

Include ICU package

690e6aa

Include the ICU libraries for linux-x64.

Make Request non-abstract

134e4ad

Make the type non-abstract to see if it fixes `NotSupportedException` when attempting to deserialize the payload.

Remove polymorphism

83eb76f

Remove polymorphism as it is not supported when the type discriminator is not the first property in the JSON document. See dotnet/runtime#72604.

Use invariant globalisation

fb45199

Use invariant globalisation and remove Microsoft.ICU.ICU4C.Runtime to reduce the AoT deployment size.

martincostello force-pushed the publish-aot branch from a0309b3 to fb45199 Compare November 26, 2023 16:52

Reduce memory to 128MB

bc1971b

Reduce memory required to 128MB (the minimum) to see if enabling AoT allows that to work.

Increase timeout

7fbccfe

Increase TfL API timeout to 7.5 seconds.

Put memory back to 192MB

242e21f

Compare the time to the same code with 128MB.

Remove verification tests

fc60961

Remove the verification tests now the JSON serialization migration is complete.

martincostello marked this pull request as ready for review November 27, 2023 09:05

martincostello merged commit 09568ce into main Nov 27, 2023
12 of 13 checks passed

martincostello deleted the publish-aot branch November 27, 2023 09:06

martincostello mentioned this pull request Nov 27, 2023

Add AoT Lambda blog post martincostello/blog#102

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish as AoT #967

Publish as AoT #967

martincostello commented Nov 25, 2023 •

edited

Loading

codecov bot commented Nov 25, 2023 •

edited

Loading

martincostello commented Nov 25, 2023

martincostello commented Nov 25, 2023

github-actions bot commented Nov 25, 2023 •

edited

Loading

martincostello commented Nov 25, 2023

github-actions bot commented Nov 25, 2023 •

edited

Loading

martincostello commented Nov 25, 2023

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 27, 2023 •

edited

Loading

Publish as AoT #967

Publish as AoT #967

Conversation

martincostello commented Nov 25, 2023 • edited Loading

codecov bot commented Nov 25, 2023 • edited Loading

Codecov Report

martincostello commented Nov 25, 2023

martincostello commented Nov 25, 2023

github-actions bot commented Nov 25, 2023 • edited Loading

martincostello commented Nov 25, 2023

github-actions bot commented Nov 25, 2023 • edited Loading

martincostello commented Nov 25, 2023

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 26, 2023

github-actions bot commented Nov 26, 2023 • edited Loading

martincostello commented Nov 27, 2023 • edited Loading

martincostello commented Nov 25, 2023 •

edited

Loading

codecov bot commented Nov 25, 2023 •

edited

Loading

github-actions bot commented Nov 25, 2023 •

edited

Loading

github-actions bot commented Nov 25, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

github-actions bot commented Nov 26, 2023 •

edited

Loading

martincostello commented Nov 27, 2023 •

edited

Loading