Make vala C code errors non-fatal #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid directly accessing `.data()`, use the `.steal()` API instead which
does proper type coercion.
```
umockdev-record.c:418:27: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘void **’
../../source/src/umockdev-record.vala:64:72: error: pointer type mismatch in conditional expression [-Werror]
```
|
Meh, rawhide and also fedora:latest fail with No, |
meson 1.4 stopped hiding valac's warnings [1], which fails compilation due to our `-Werror=` settings. There's not much that we can do at this point, so stop making them non-fatal. This reverts the `gentoo-hacks` option from commit 539af0b. Turns out that this wasn't a compiler change in Gentoo after all, but that Gentoo backported [2] that meson change at that time. Many thanks to Dominique Leuenberger @DimStar77 for tracking down the root cause! Fixes #228 [1] mesonbuild/meson@5f659af870011e [2] gentoo/gentoo#34141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meson 1.4 stopped hiding valac's warnings [1], which fails compilation
due to our
-Werror=settings. There's not much that we can do at thispoint, so stop making them non-fatal.
This reverts the
gentoo-hacksoption from commit 539af0b. Turnsout that this wasn't a compiler change in Gentoo after all, but that
Gentoo backported [2] that meson change at that time.
Many thanks to Dominique Leuenberger @DimStar77 for tracking down the
root cause!
Fixes #228
[1] mesonbuild/meson@5f659af870011e
[2] gentoo/gentoo#34141