Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vala C code errors non-fatal #229

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Make vala C code errors non-fatal #229

merged 2 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. umockdev-record: Fix all_devices() type conversion 

    Avoid directly accessing `.data()`, use the `.steal()` API instead which
does proper type coercion.

```
umockdev-record.c:418:27: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘void **’
../../source/src/umockdev-record.vala:64:72: error: pointer type mismatch in conditional expression [-Werror]
```
    @martinpitt
    martinpitt committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b842b14 View commit details
    Browse the repository at this point in the history

  2. Make vala C code errors non-fatal 

    meson 1.4 stopped hiding valac's warnings [1], which fails compilation
due to our `-Werror=` settings. There's not much that we can do at this
point, so stop making them non-fatal.

This reverts the `gentoo-hacks` option from commit 539af0b. Turns
out that this wasn't a compiler change in Gentoo after all, but that
Gentoo backported [2] that meson change at that time.

Many thanks to Dominique Leuenberger @DimStar77 for tracking down the
root cause!

Fixes #228

[1] mesonbuild/meson@5f659af870011e
[2] gentoo/gentoo#34141
    @martinpitt
    martinpitt committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    72a14ce View commit details
    Browse the repository at this point in the history