Fix the settings screen layout issue #415
Conversation
After migrating to AndroidX, The icon space is reserved by default in preference screens. This behavior is fixed by overriding the preference file.
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Why is this in values-sw-360dp-v13? Couldn't it just be in values?
There was a problem hiding this comment.
I tried it putting it in values but it didn't work. You can refer to this thread, https://stackoverflow.com/questions/18509369/android-how-to-remove-margin-padding-in-preference-screen
|
|
||
| <!--Created By Me to fix the appearance issue caused by migrating to AndroidX--> | ||
| <resources xmlns:tools="http://schemas.android.com/tools"> | ||
| <bool name="config_materialPreferenceIconSpaceReserved" tools:ignore="MissingDefaultResource,PrivateResource">false</bool> |
There was a problem hiding this comment.
Seems like this should be overridden in the theme itself. Does it help to change preferenceTheme in styles.xml with a new style that contains this attribute?
<item name="iconSpaceReserved">false</item>
There was a problem hiding this comment.
This may work, I think. But this attribute doesn't work for PreferenceCategory (The title of the preference).
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
|
|
|||
| <!--Created By Me to fix the appearance issue caused by migrating to AndroidX--> | |||
There was a problem hiding this comment.
We shouldn't need a comment for this -- the git history can add this context 🙂
There was a problem hiding this comment.
Nvm about that comment. i have changed so many files till now. I have put there everywhere in my local copy just incase if anything breaks, I know exactly where to look at. 😄
Edit:Screenshot Updated.
After migrating to AndroidX, The icon space is reserved by default in preference screens. This behavior is fixed by overriding the preference file.
Testing Steps
Open the Settings from the App and observe the space in the left is gone.
Update: Screenshot attached of the Settings screen. I dont have previous version of app on my phone now, but I guess you already know the issue.