Fix the settings screen layout issue #415
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
|
|
||
| <!--Created By Me to fix the appearance issue caused by migrating to AndroidX--> | ||
|
There was a problem hiding this comment. We shouldn't need a comment for this -- the git history can add this context 🙂 There was a problem hiding this comment. Nvm about that comment. i have changed so many files till now. I have put there everywhere in my local copy just incase if anything breaks, I know exactly where to look at. 😄 Edit:Screenshot Updated. |
||
| <resources xmlns:tools="http://schemas.android.com/tools"> | ||
| <bool name="config_materialPreferenceIconSpaceReserved" tools:ignore="MissingDefaultResource,PrivateResource">false</bool> | ||
|
There was a problem hiding this comment. Seems like this should be overridden in the theme itself. Does it help to change <item name="iconSpaceReserved">false</item>
There was a problem hiding this comment. This may work, I think. But this attribute doesn't work for PreferenceCategory (The title of the preference). |
||
| <dimen name="preference_category_padding_start" tools:ignore="MissingDefaultResource,PrivateResource">0dp</dimen> | ||
| </resources> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in
values-sw-360dp-v13? Couldn't it just be invalues?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it putting it in values but it didn't work. You can refer to this thread, https://stackoverflow.com/questions/18509369/android-how-to-remove-margin-padding-in-preference-screen