Solved the task #2741
Open
Solved the task #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleziO
suggested changes
Dec 26, 2023
src/transformState.js
Outdated
| @@ -6,6 +6,25 @@ | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
Viktor-Kost
suggested changes
Dec 26, 2023
src/transformState.js
Outdated
Comment on lines
9
to
10
| for (const action of actions) { | ||
| if (action.type === 'clear') { |
There was a problem hiding this comment.
- use object destructing for
action - it'd much better to use
switchcase here instead ofif - it is a good practice when you add a default behavior for
switchstatement. Yet, if you don't have such one - just throw an Error with text like "unexpected action"
anastasiia-tilikina
suggested changes
Dec 27, 2023
src/transformState.js
Outdated
| for (const action of actions) { | ||
| const { type, extraData, keysToRemove } = action; | ||
|
|
||
| switch (true) { |
There was a problem hiding this comment.
don't use true in switch statement. use type instead
src/transformState.js
Outdated
| } | ||
|
|
||
| default: | ||
| return 'Unexpected acrion'; |
There was a problem hiding this comment.
Suggested change
| return 'Unexpected acrion'; | |
| return 'Unexpected action'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.