Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the task #2741

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solved the task #2741

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb9da7
Solved the task
natalia-matash Dec 26, 2023
aa77cac
Implement changes
natalia-matash Dec 27, 2023
38e2f0b
Change switch statement
natalia-matash Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/transformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,25 @@
*/
function transformState(state, actions) {
// write code here
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments

for (const action of actions) {
if (action.type === 'clear') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. use object destructing for action
  2. it'd much better to use switch case here instead of if
  3. it is a good practice when you add a default behavior for switch statement. Yet, if you don't have such one - just throw an Error with text like "unexpected action"

for (const s in state) {
delete state[s];
}
}

if (action.type === 'addProperties') {
Object.assign(state, action.extraData);
}

if (action.type === 'removeProperties') {
for (const key of action.keysToRemove) {
delete state[key];
}
}
}

return state;
}

module.exports = transformState;
Loading