Develop #4924
Open
Develop #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinaminahi
suggested changes
May 3, 2024
images/moyo_1.png
Outdated
There was a problem hiding this comment.
Please, remove this and let's use existing logo image in src/images folder
src/index.html
Outdated
Comment on lines
35
to
39
| <img | ||
| src="./images/logo.png" | ||
| alt="Moyo logo" | ||
| class="logo" | ||
| /> |
There was a problem hiding this comment.
Not critical, but better to format it
src/style.css
Outdated
| html { | ||
| font-family: Roboto, sans-serif; | ||
| font-weight: 500; | ||
| font-style: normal; |
There was a problem hiding this comment.
Suggested change
| font-style: normal; |
It is default style
src/style.css
Outdated
Comment on lines
5
to
7
| * { | ||
| box-sizing: border-box; | ||
| } |
dinaminahi
approved these changes
May 3, 2024
There was a problem hiding this comment.
Let's remove this and use the image from src/images folder
Comment on lines
+42
to
+44
| <a | ||
| href="#" | ||
| > |
There was a problem hiding this comment.
If we have 1 or two attributes we place it in one line
Suggested change
| <a | |
| href="#" | |
| > | |
| <a href="#"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️