Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4924

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+187 −6
Open

Develop #4924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be46a44
add solution
om1gse May 2, 2024
0c88f0d
add link for logo
om1gse May 2, 2024
4f7dd90
editing fails
om1gse May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added images/moyo_1.png
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this and use the image from src/images folder

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@mate-academy/backstop-config": "latest",
"@mate-academy/bemlint": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.7.3",
"@mate-academy/scripts": "^1.8.1",
"@mate-academy/stylelint-config": "latest",
"backstopjs": "6.2.2",
"jest": "^29.7.0",
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://om1gse.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://om1gse.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
126 changes: 123 additions & 3 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,139 @@
<meta charset="UTF-8" />
<meta
name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"
content="width=device-width,
user-scalable=no,
initial-scale=1.0,
maximum-scale=1.0,
minimum-scale=1.0"
/>
<meta
http-equiv="X-UA-Compatible"
content="ie=edge"
/>
<title>Moyo header</title>
<title>
Moyo header
</title>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="anonymous"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500&display=swap"
rel="stylesheet"
/>
<link
rel="stylesheet"
href="./style.css"
/>
</head>
<body>
<h1>Moyo header</h1>
<header
class="header"
>
<a
href="#"
>
Comment on lines +42 to +44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have 1 or two attributes we place it in one line

Suggested change
<a
href="#"
>
<a href="#">

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies to all code

<img
src="images/logo.png"
alt="Moyo logo"
class="logo"
/>
</a>
<nav
class="nav"
>
<ul
class="nav__list"
>
<li
class="nav__item"
>
<a
href="#1"
class="nav__link is-active"
>
Apple
</a>
</li>
<li
class="nav__item"
>
<a
href="#2"
class="nav__link"
>
Samsung
</a>
</li>
<li
class="nav__item"
>
<a
href="#3"
class="nav__link"
>
Smartphones
</a>
</li>
<li
class="nav__item"
>
<a
href="#4"
class="nav__link"
data-qa="hover"
>
Laptops & Computers
</a>
</li>
<li
class="nav__item"
>
<a
href="#5"
class="nav__link"
>
Gadgets
</a>
</li>
<li
class="nav__item"
>
<a
href="#6"
class="nav__link"
>
Tablets
</a>
</li>
<li
class="nav__item"
>
<a
href="#7"
class="nav__link"
>
Photo
</a>
</li>
<li
class="nav__item"
>
<a
href="#8"
class="nav__link"
>
Video
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
61 changes: 61 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,64 @@
body {
margin: 0;
}

html {
font-family: Roboto, sans-serif;
font-weight: 500;
font-size: 12px;
line-height: 14px;

--main-color: #00acdc;
}

.header {
display: flex;
justify-content: space-between;
align-items: center;
padding-inline: 50px;
box-shadow: 0 2px 4px 0 #0000000d;
}

.nav__list {
display: flex;

list-style: none;
gap: 20px;
padding: 0;
margin: 0;
}

.nav__link {
position: relative;

display: flex;
align-items: center;
height: 60px;

padding: 0;
margin: 0;

text-decoration: none;
color: #000;
text-transform: uppercase;
font: inherit;
}

.nav__link:hover,
.is-active {
color: var(--main-color);
}

.is-active::after {
content: '';

display: block;
position: absolute;
left: 0;
right: 0;
bottom: 0;

height: 4px;
background-color: var(--main-color);
border-radius: 8px;
}
Loading