add task solution #4930
Open
add task solution #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ell10tt
commented
May 6, 2024
ell10tt
commented
- Header height is set in 1 place (for the links)
- Content is vertically centered (for any header height)
- CSS is used to show all letters in Uppercase (don't type them in HTML)
- Logo is an image wrapped with a link
- CSS Variable is used for a blue color
- Pseudo-element is used for a blue line below the active link
- Code follows all the Code Style Rules ❗️
vadiimvooo
suggested changes
May 6, 2024
src/style.css
Outdated
| height: 40px; | ||
| } | ||
|
|
||
| ul { |
src/style.css
Outdated
| @@ -1,3 +1,90 @@ | |||
| body { | |||
| margin: 0; | |||
| } | |||
|
|
|||
| header { | |||
| header { | ||
| font-size: 12px; | ||
| text-transform: uppercase; | ||
| box-sizing: border-box; |
src/style.css
Outdated
| text-transform: uppercase; | ||
| box-sizing: border-box; | ||
| width: 100vw; | ||
| background-color: #ffff; |
There was a problem hiding this comment.
Suggested change
| background-color: #ffff; | |
| background-color: #fff; |
src/style.css
Outdated
Comment on lines
50
to
56
| .page-link:hover { | ||
| color: #00acdc; | ||
| } | ||
|
|
||
| .is-active { | ||
| color: #00acdc; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .page-link:hover { | |
| color: #00acdc; | |
| } | |
| .is-active { | |
| color: #00acdc; | |
| } | |
| .page-link:hover, | |
| .is-active { | |
| color: #00acdc; | |
| } |
src/style.css
Outdated
Comment on lines
72
to
88
| .roboto-regular { | ||
| font-family: Roboto, sans-serif; | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| } | ||
|
|
||
| .roboto-medium { | ||
| font-family: Roboto, sans-serif; | ||
| font-weight: 500; | ||
| font-style: normal; | ||
| } | ||
|
|
||
| .roboto-bold { | ||
| font-family: Roboto, sans-serif; | ||
| font-weight: 700; | ||
| font-style: normal; | ||
| } |
There was a problem hiding this comment.
This part looks redundant. Just connect font-family and font-style to html selector and use appropriate font-weight in other selectors
etojeDenys
suggested changes
May 7, 2024
src/index.html
Outdated
Comment on lines
45
to
50
| <a | ||
| class="page-link is-active" | ||
| href="#" | ||
| > | ||
| <li>Apple</li> | ||
| </a> |
There was a problem hiding this comment.
Suggested change
| <a | |
| class="page-link is-active" | |
| href="#" | |
| > | |
| <li>Apple</li> | |
| </a> | |
| <li | |
| class="nav__item" | |
| > | |
| <a href="#" class="nav__link is-active">Apple</a> | |
| </li> |
tag a should be inside the li
src/style.css
Outdated
|
|
||
| .page-link:hover, | ||
| .is-active { | ||
| color: #00acdc; |
There was a problem hiding this comment.
better to move it to some var and reuse everywhere
GUSILLUS
suggested changes
May 8, 2024
src/index.html
Outdated
Comment on lines
42
to
43
| </a> | ||
| <nav class="roboto-medium"> |
There was a problem hiding this comment.
Add space between elements on one level depths
src/index.html
Outdated
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Consider making links nearest to real practice change from # to actual name /apple in this case
GUSILLUS
approved these changes
May 9, 2024
| <nav class="roboto-medium"> | ||
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| href="https://www.moyo.ua/portal_brand/apple_1/" |
There was a problem hiding this comment.
I mean just write /apple but okay) I approve it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.