Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4930

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add task solution #4930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90533da
add task solution
ell10tt May 6, 2024
0f8849f
redacted all of mistakes
ell10tt May 7, 2024
49f1d27
added requested file
ell10tt May 7, 2024
c71e72c
added requested file
ell10tt May 7, 2024
fc82cb2
Merge branch 'develop' of https://github.com/ell10tt/layout_moyo-head…
ell10tt May 7, 2024
e5c2e36
maked requested changes
ell10tt May 8, 2024
262378d
provided links to all categories in navigation-bar
ell10tt May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Moyo header

Create HTML page with the header using `flexbox` based on the [Figma Mockup](https://www.figma.com/file/1sog2rmfyCjnVxkeZ3ptnc/MOYO-%2F-Header?node-id=0%3A1&mode=dev).

The page should match the design Pixel Perfect: all the sizes, colors and distanced MUST be the same as on the design.
Expand Down Expand Up @@ -27,8 +28,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://ell10tt.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://ell10tt.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
85 changes: 84 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,91 @@
rel="stylesheet"
href="./style.css"
/>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>
</head>
<body>
<h1>Moyo header</h1>
<header>
<a
href="index.html"
class="logo-link"
>
<img
src="images/logo.png"
alt="sorry we dont have any images now"
class="logo"
/>
</a>
<nav class="roboto-medium">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space between elements on one level depths

<ul>
<a
class="page-link is-active"
href="#"
>
<li>Apple</li>
</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a
class="page-link is-active"
href="#"
>
<li>Apple</li>
</a>
<li
class="nav__item"
>
<a href="#" class="nav__link is-active">Apple</a>
</li>

tag a should be inside the li


<a
class="page-link"
href="#"
>
<li>Samsung</li>
</a>

<a
class="page-link"
href="#"
>
<li>Smartphones</li>
</a>

<a
class="page-link"
data-qa="hover"
href="#"
>
<li>Laptops & Computers</li>
</a>

<a
class="page-link"
href="#"
>
<li>Gadgets</li>
</a>

<a
class="page-link"
href="#"
>
<li>Tablets</li>
</a>

<a
class="page-link"
href="#"
>
<li>Photo</li>
</a>

<a
class="page-link"
href="#"
>
<li>Video</li>
</a>
</ul>
</nav>
</header>
</body>
</html>
87 changes: 87 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,90 @@
body {
margin: 0;
}

header {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use class selector here

font-size: 12px;
text-transform: uppercase;
box-sizing: border-box;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this style with * selector

width: 100vw;
background-color: #ffff;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: #ffff;
background-color: #fff;

display: flex;
align-items: center;
justify-content: space-between;

padding: 0 50px;
}

.logo-link {
display: block;
width: 40px;
height: 40px;
}

.logo {
width: 40px;
height: 40px;
}

ul {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use class selector here

display: flex;
padding: 0;
margin: 0;
list-style: none;
}

.page-link {
margin-left: 20px;
position: relative;
display: flex;
align-items: center;
height: 60px;
text-decoration: none;
color: #000;
}

.page-link:first-child {
margin-left: 0;
}

.page-link:hover {
color: #00acdc;
}

.is-active {
color: #00acdc;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to move it to some var and reuse everywhere

}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.page-link:hover {
color: #00acdc;
}
.is-active {
color: #00acdc;
}
.page-link:hover,
.is-active {
color: #00acdc;
}


.is-active::after {
content: '';
position: absolute;
bottom: 0;
left: 0;
right: 0;
width: 37px;
height: 4px;
border-radius: 8px;
background-color: #00acdc;
}

/* #REGION start */

.roboto-regular {
font-family: Roboto, sans-serif;
font-weight: 400;
font-style: normal;
}

.roboto-medium {
font-family: Roboto, sans-serif;
font-weight: 500;
font-style: normal;
}

.roboto-bold {
font-family: Roboto, sans-serif;
font-weight: 700;
font-style: normal;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks redundant. Just connect font-family and font-style to html selector and use appropriate font-weight in other selectors


/* #REGION end */
Loading