Develop #5335
Open
Develop #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmohnach
commented
Sep 3, 2024
vmohnach
commented
- DEMO LINK
- TEST REPORT LINK
etojeDenys
suggested changes
Sep 3, 2024
src/style.css
Outdated
Comment on lines
12
to
45
| header { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| position: relative; | ||
| } | ||
|
|
||
| img { | ||
| margin: 10px 50px; | ||
| } | ||
|
|
||
| nav { | ||
| margin-right: 50px; | ||
| } | ||
|
|
||
| ul { | ||
| list-style-type: none; | ||
| padding: 0; | ||
| margin: 0; | ||
| display: flex; | ||
| } | ||
|
|
||
| li { | ||
| margin-left: 20px; | ||
| } | ||
|
|
||
| li:first-child { | ||
| margin-left: 0; | ||
| } | ||
|
|
||
| li:last-child { | ||
| margin-right: 0; | ||
| } | ||
|
|
src/style.css
Outdated
Comment on lines
12
to
21
| header { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| position: relative; | ||
| } | ||
|
|
||
| img { | ||
| margin: 10px 50px; | ||
| } |
There was a problem hiding this comment.
Suggested change
| header { | |
| display: flex; | |
| justify-content: space-between; | |
| align-items: center; | |
| position: relative; | |
| } | |
| img { | |
| margin: 10px 50px; | |
| } | |
| header { | |
| display: flex; | |
| justify-content: space-between; | |
| align-items: center; | |
| position: relative; | |
| padding: 0 50px; | |
| } | |
| img { | |
| margin: 10px 0; | |
| } |
src/style.css
Outdated
| } | ||
|
|
||
| nav { | ||
| margin-right: 50px; |
Co-authored-by: Denys Semtso <[email protected]>
etojeDenys
suggested changes
Sep 3, 2024
volodymyr-soltys97
suggested changes
Sep 4, 2024
src/index.html
Outdated
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@100;300;400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
|
|
||
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> |
There was a problem hiding this comment.
Remove it
Suggested change
| <h1>Moyo header</h1> |
etojeDenys
suggested changes
Sep 4, 2024
src/index.html
Outdated
|
|
||
| <nav class="nav"> | ||
| <ul class="nav_list"> | ||
| <li class="nav-item"> <a href="#apple" class="is-active button-link">APPLE</a></li> |
There was a problem hiding this comment.
Suggested change
| <li class="nav-item"> <a href="#apple" class="is-active button-link">APPLE</a></li> | |
| <li class="nav-item"> | |
| <a href="#apple" class="is-active button-link"> | |
| APPLE | |
| </a> | |
| </li> |
etojeDenys
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.