Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5335

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Develop #5335

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5123f2b
add task solution
vmohnach Sep 3, 2024
f1c37c6
add a page title
vmohnach Sep 3, 2024
ec216d1
Update src/style.css
vmohnach Sep 3, 2024
ce773be
add task solution
vmohnach Sep 3, 2024
934273c
Merge branch 'master' into develop
vmohnach Sep 3, 2024
a5bf282
conflicts are resolved
vmohnach Sep 3, 2024
6e4d1fa
correction
vmohnach Sep 4, 2024
ede450e
Merge branch 'develop' of https://github.com/vmohnach/layout_moyo-hea…
vmohnach Sep 4, 2024
09bc5bb
correction
vmohnach Sep 4, 2024
44e35b0
correction2
vmohnach Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://vmohnach.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://vmohnach.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
35 changes: 34 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,46 @@
http-equiv="X-UA-Compatible"
content="ie=edge"
/>

<title>Moyo header</title>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@100;300;400;500;700&display=swap"
rel="stylesheet"
/>

<link
rel="stylesheet"
href="./style.css"
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="header">
<img
class="logo"
src="images/logo.png"
alt="logo"
/>

<nav class="nav">
<ul class="nav_list">
<li class="nav-item"> <a href="#apple" class="is-active button-link">APPLE</a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li class="nav-item"> <a href="#apple" class="is-active button-link">APPLE</a></li>
<li class="nav-item">
<a href="#apple" class="is-active button-link">
APPLE
</a>
</li>

<li class="nav-item"><a href="#samsung" class="button-link">SAMSUNG</a></li>
<li class="nav-item"><a href="#smartphones" class="button-link">SMARTPHONES</a></li>
<li class="nav-item"><a class="button-link" href="#laptops & computers" data-qa="hover">LAPTOPS & COMPUTERS</a></li>
<li class="nav-item"><a href="#gadgets" class="button-link">GADGETS</a></li>
<li class="nav-item"><a href="#tablets"class="button-link">TABLETS</a></li>
<li class="nav-item"><a href="#photo"class="button-link">PHOTO</a></li>
<li class="nav-item"><a href="#video"class="button-link">VIDEO</a></li>
</ul>
</nav>
</header>
</body>
</html>
62 changes: 62 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,65 @@
body {
margin: 0;
font-size: 12px;
font-family: Roboto, sans-serif;
font-weight: 500;
}

.header {
display: flex;
justify-content: space-between;
align-items: center;
position: relative;
padding: 0 50px;
}

img {
margin: 10px 0;
}

.nav_list {
list-style-type: none;
padding: 0;
margin: 0;
display: flex;
}

.nav-item {
margin-left: 20px;
}

.nav-item:first-child {
margin-left: 0;
}

.nav-item:last-child {
margin-right: 0;
}

.button-link {
text-decoration: none;
color: black;
position: relative;
display: inline-block;
line-height: 60px;
}

.button-link.is-active {
color: #00acdc;
}

.button-link.is-active::after {
content: '';
display: block;
height: 4px;
width: 100%;
background-color: #00acdc;
position: absolute;
left: 0;
bottom: 0;
border-radius: 2px;
}

.button-link:hover {
color: #00acdc;
}
Loading