-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5845
base: master
Are you sure you want to change the base?
Develop #5845
Conversation
Anna-0805
commented
Dec 20, 2024
•
edited
Loading
edited
- DEMO LINK
- TEST REPORT LINK
- Высота заголовка задается в 1 месте (для ссылок)
- Содержимое выравнивается по вертикали (для любой высоты заголовка)
- CSS используется для отображения всех букв в верхнем регистре (не вводите их в HTML)
- Логотип — это изображение, заключенное в ссылку.
- Переменная CSS используется для синего цвета
- Псевдоэлемент используется для синей линии под активной ссылкой
- Код соответствует всем [правилам стиля кода ❗️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed to meet the task requirements fully. Here are the key points to focus on:
-
Logo Link: The logo needs to be wrapped in an
<a>
tag with a validhref
attribute linking to the homepage or a relevant page. This is essential for navigation functionality. -
CSS Variable for Blue Color: A CSS variable should be used for the blue color instead of directly using the color value
#00acdc
. This will enhance maintainability and consistency. -
Link Attributes: The
href
attribute for the "Laptops & Computers" link contains an invalid value#l&c
. Please correct this to ensure proper URL encoding and functionality.
These changes are crucial for the functionality and core requirements of the task. Once these are addressed, your code will be in great shape! Keep up the good work, and I look forward to seeing the improvements. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing most of the issues from the previous review! 🎉 Your solution is approved to help you move forward with your learning journey. However, there are a few critical points to consider for future improvements:
-
Logo Link: The logo is now correctly wrapped in an
<a>
tag, but thehref
attribute should point to the homepage or a relevant page instead of an image URL. This is crucial for proper navigation. -
CSS Variable for Blue Color: You've successfully implemented the CSS variable
--blue-color
. Ensure it is used consistently throughout your styles to maintain uniformity and ease of updates. -
Link Attributes: The
href
attribute for the "Laptops & Computers" link is currently set to#lc
, which is a valid URL fragment. Ensure that all links are functional and correctly encoded.
Please review these comments to improve your code. Addressing these issues will enhance the functionality and maintainability of your project. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
<a | ||
href="https://s3-alpha-sig.figma.com/img/833f/9aab/47d660efd384318772b6b8040db831aa?Expires=1735516800&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=QZ6lDmSpPbHeqT6gx2d4ZGNPU8LtHi2aEk~52e~6cOVwfkoMC7XOPL4U4W1xi6nsET5fKBG-6anx9moX1kG2ojI9ybSZVp~wvLo1FQNCSLJ2VQaovKKdEdu9QS~nc1y7eQUjzQ3cc~dcc4TiSv8NTaaU~LO3Y0BqW8AdW8udXTDWtPXujxk0DcitGrla8txLiT95QDpl00-sxZAO7HUlXZnNlstj-lG~aihOdrPfcQoouTWmnrb0pHmmtQ-naqsO-~~dW63bzNqj5-~g6m94uZI1J-6PqsE9uYyrA3EKtq2jquuZCFc~o930E55ToOkD3DptflqLKky-zEe-HWvxzg__" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo should be wrapped in an <a>
tag with a valid href
attribute linking to the homepage or a relevant page. Currently, the href
attribute contains a URL to an image, which is incorrect. Please update this to link to the homepage or a relevant page.
src/index.html
Outdated
<a | ||
href="#lc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute for the 'Laptops & Computers' link contains an invalid value #lc
. Ensure proper URL encoding and functionality by using a valid URL or anchor.
src/style.css
Outdated
.panel a { | ||
text-transform: uppercase; | ||
text-align: center; | ||
color: #000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the CSS variable var(--blue-color)
for the color property here instead of the hardcoded value #000
. This will ensure consistency and make it easier to update the color scheme in the future.