-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5845
base: master
Are you sure you want to change the base?
Develop #5845
Changes from 10 commits
fb77b3e
3b96c56
e0fd37c
d2528b9
ebdbd47
aa77320
d1f7bee
1819ec9
c325544
131e3d8
3d4993a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,20 +3,81 @@ | |
<head> | ||
<meta charset="UTF-8" /> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0" | ||
http-equiv="X-UA-Compatible" | ||
content="IE=edge" | ||
/> | ||
<meta | ||
http-equiv="X-UA-Compatible" | ||
content="ie=edge" | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0" | ||
/> | ||
<title>MOYO Header</title> | ||
<link | ||
rel="stylesheet" | ||
href="style.css" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.googleapis.com" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
crossorigin="anonymous" | ||
/> | ||
<title>Moyo header</title> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap" | ||
rel="stylesheet" | ||
href="./style.css" | ||
/> | ||
</head> | ||
<body> | ||
<h1>Moyo header</h1> | ||
<header class="header"> | ||
<a | ||
href="https://s3-alpha-sig.figma.com/img/833f/9aab/47d660efd384318772b6b8040db831aa?Expires=1735516800&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=QZ6lDmSpPbHeqT6gx2d4ZGNPU8LtHi2aEk~52e~6cOVwfkoMC7XOPL4U4W1xi6nsET5fKBG-6anx9moX1kG2ojI9ybSZVp~wvLo1FQNCSLJ2VQaovKKdEdu9QS~nc1y7eQUjzQ3cc~dcc4TiSv8NTaaU~LO3Y0BqW8AdW8udXTDWtPXujxk0DcitGrla8txLiT95QDpl00-sxZAO7HUlXZnNlstj-lG~aihOdrPfcQoouTWmnrb0pHmmtQ-naqsO-~~dW63bzNqj5-~g6m94uZI1J-6PqsE9uYyrA3EKtq2jquuZCFc~o930E55ToOkD3DptflqLKky-zEe-HWvxzg__" | ||
class="logo" | ||
> | ||
<img | ||
src="https://s3-alpha-sig.figma.com/img/833f/9aab/47d660efd384318772b6b8040db831aa?Expires=1735516800&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=QZ6lDmSpPbHeqT6gx2d4ZGNPU8LtHi2aEk~52e~6cOVwfkoMC7XOPL4U4W1xi6nsET5fKBG-6anx9moX1kG2ojI9ybSZVp~wvLo1FQNCSLJ2VQaovKKdEdu9QS~nc1y7eQUjzQ3cc~dcc4TiSv8NTaaU~LO3Y0BqW8AdW8udXTDWtPXujxk0DcitGrla8txLiT95QDpl00-sxZAO7HUlXZnNlstj-lG~aihOdrPfcQoouTWmnrb0pHmmtQ-naqsO-~~dW63bzNqj5-~g6m94uZI1J-6PqsE9uYyrA3EKtq2jquuZCFc~o930E55ToOkD3DptflqLKky-zEe-HWvxzg__" | ||
alt="Moyo" | ||
Anna-0805 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/> | ||
</a> | ||
<nav class="panel"> | ||
<ul> | ||
<li> | ||
<a | ||
href="#apple" | ||
class="is-active" | ||
> | ||
Apple | ||
</a> | ||
</li> | ||
<li> | ||
<a href="#samsung">Samsung</a> | ||
</li> | ||
<li> | ||
<a href="#smartphones">Smartphones</a> | ||
</li> | ||
<li> | ||
<a | ||
href="#lc" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
data-qa="hover" | ||
> | ||
Laptops & Computers | ||
</a> | ||
</li> | ||
<li> | ||
<a href="#gadgets">Gadgets</a> | ||
</li> | ||
<li> | ||
<a href="#tablets">Tablets</a> | ||
</li> | ||
<li> | ||
<a href="#photo">Photo</a> | ||
</li> | ||
<li> | ||
<a href="#video">Video</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
</header> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,82 @@ | ||
body { | ||
margin: 0; | ||
font-family: Roboto, sans-serif; | ||
} | ||
|
||
.header { | ||
background-color: #fff; | ||
padding: 0 50px; | ||
display: flex; | ||
justify-content: space-between; | ||
} | ||
|
||
.panel ul { | ||
margin: 0; | ||
padding: 0; | ||
list-style: none; | ||
display: flex; | ||
} | ||
|
||
li { | ||
display: inline-flex; | ||
justify-content: center; | ||
align-items: center; | ||
height: 60px; | ||
margin-right: 20px; | ||
} | ||
|
||
.panel a { | ||
text-transform: uppercase; | ||
text-align: center; | ||
color: #000; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using the CSS variable |
||
font-size: 12px; | ||
font-weight: 500; | ||
line-height: 60px; | ||
text-decoration: none; | ||
display: block; | ||
} | ||
|
||
a:link, | ||
a:visited, | ||
a:active { | ||
color: inherit; | ||
background-color: transparent; | ||
} | ||
|
||
li:last-child { | ||
margin-right: 0; | ||
} | ||
|
||
.logo img { | ||
width: 40px; | ||
height: 40px; | ||
padding-top: 10px; | ||
} | ||
|
||
.panel a.is-active { | ||
color: var(--blue-color); | ||
position: relative; | ||
} | ||
|
||
.panel a.is-active::after { | ||
content: ''; | ||
position: absolute; | ||
left: 0; | ||
bottom: 0; | ||
width: 100%; | ||
height: 4px; | ||
background-color: var(--blue-color); | ||
border-radius: 8px; | ||
} | ||
|
||
.panel a:hover { | ||
color: var(--blue-color); | ||
} | ||
|
||
.panel .is-active a:hover { | ||
color: var(--blue-color); | ||
} | ||
|
||
:root { | ||
--blue-color: #00acdc; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo should be wrapped in an
<a>
tag with a validhref
attribute linking to the homepage or a relevant page. Currently, thehref
attribute contains a URL to an image, which is incorrect. Please update this to link to the homepage or a relevant page.