-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4735
base: master
Are you sure you want to change the base?
add task solution #4735
Conversation
anhrytsan
commented
Jan 29, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While you've made a great start, there are a few critical issues that need to be addressed to meet the task requirements fully:
-
HTML Structure and Attributes: The HTML file is missing the required
data-qa
attributes for the search bars. These attributes are essential for identifying the search forms as "big" and "small." -
CSS Styling: The search bars need to stretch the full width of their container, and there should be a 20px gap between them. These layout requirements are crucial for the design specification.
-
Form and Input Elements: Ensure that the
<form>
tag is not self-closing. It should have a separate closing tag</form>
to maintain proper HTML structure.
Please address these issues to ensure your code meets the core requirements. Keep up the great work, and I'm confident you'll nail it with these adjustments! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
<form | ||
action="#" | ||
class="form" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <form>
tag should not be self-closing. It should have a separate closing tag </form>
instead of using a self-closing syntax. This is important for proper HTML structure and to ensure that the form elements are correctly nested within the form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress! You've made some important updates, like adding the data-qa
attributes to the search bars. However, there are a few critical issues to address:
-
HTML Structure: The
<form>
tag is self-closing, which is not valid HTML. Ensure it has a separate closing tag</form>
to maintain proper structure. -
CSS Styling: The search bars need to stretch the full width of their container. Consider adding
width: 100%;
to the.form
class or input elements. Also, ensure there's a 20px gap between the search bars, possibly by adjusting the margin or padding.
These improvements are crucial for the functionality and appearance of your code. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<form | ||
action="#" | ||
class="form" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <form>
tag is incorrectly self-closing. According to HTML specifications, the <form>
tag should have a separate closing tag </form>
. Please update this to maintain proper HTML structure.
.form { | ||
display: flex; | ||
flex-direction: column; | ||
color: #3d4e61; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .form
class should include styles to ensure the search bars stretch the full width of their container. Consider adding width: 100%;
to the .form
class or the input elements to achieve this.
.form__input--first { | ||
height: 70px; | ||
margin: 20px 0; | ||
font-size: 16px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain a 20px gap between the search bars, you should adjust the margin or padding. Currently, the .form__input--first
has a margin: 20px 0;
, which might not be sufficient to ensure the required gap between the two input fields.