-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4735
base: master
Are you sure you want to change the base?
add task solution #4735
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,16 +17,23 @@ | |
/> | ||
</head> | ||
<body> | ||
<input | ||
type="text" | ||
data-qa="keypress" | ||
placeholder="Try “Los Angeles“" | ||
/> | ||
<form | ||
action="#" | ||
class="form" | ||
> | ||
Comment on lines
+20
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
<input | ||
type="text" | ||
data-qa="big" | ||
placeholder="Try “Los Angeles“" | ||
class="form__input form__input--first" | ||
/> | ||
|
||
<input | ||
type="text" | ||
data-qa="hover" | ||
placeholder="Try “Los Angeles“" | ||
/> | ||
<input | ||
type="text" | ||
data-qa="small" | ||
placeholder="Try “Los Angeles“" | ||
class="form__input form__input--second" | ||
/> | ||
</form> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,82 @@ | ||
/* add styles here */ | ||
@font-face { | ||
font-family: Avenir; | ||
src: url(fonts/Avenir-Book.ttf); | ||
font-weight: 300; | ||
font-style: normal; | ||
} | ||
|
||
@font-face { | ||
font-family: Avenir; | ||
src: url(fonts/Avenir-Heavy.ttf); | ||
font-weight: 900; | ||
} | ||
|
||
body { | ||
margin-top: 0; | ||
font-family: Avenir, sans-serif; | ||
} | ||
|
||
.form { | ||
display: flex; | ||
flex-direction: column; | ||
color: #3d4e61; | ||
} | ||
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
.form__input { | ||
background-image: url(images/Search.svg); | ||
background-repeat: no-repeat; | ||
background-position: 25px center; | ||
background-size: 19px; | ||
padding-left: 62px; | ||
box-sizing: border-box; | ||
border: 1px solid #e1e7ed; | ||
border-radius: 4px; | ||
box-shadow: 0 1px 8px rgba(61, 78, 97, 0.1); | ||
font-weight: 300; | ||
font-family: inherit; | ||
outline: none; | ||
} | ||
|
||
.form__input::placeholder { | ||
color: #3d4e61; | ||
font-weight: 300; | ||
line-height: 21.86px; | ||
} | ||
|
||
.form__input--first { | ||
height: 70px; | ||
margin: 20px 0; | ||
font-size: 16px; | ||
} | ||
Comment on lines
+46
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To maintain a 20px gap between the search bars, you should adjust the margin or padding. Currently, the |
||
|
||
.form__input--second { | ||
height: 42px; | ||
font-size: 14px; | ||
padding-left: 33px; | ||
background-position: 12px center; | ||
background-size: 11px; | ||
} | ||
|
||
.form__input:focus { | ||
outline: none; | ||
box-shadow: 0 3px 8px rgba(61, 78, 97, 0.2); | ||
border-radius: 3px; | ||
border-color: #3d4e61; | ||
background-image: url(images/Search.svg), | ||
linear-gradient(180deg, #fff 0%, #f6f6f7 100%); | ||
background-repeat: no-repeat; | ||
background-size: 19px, 100%; | ||
font-weight: 600; | ||
} | ||
|
||
.form__input--second:focus { | ||
background-position: | ||
13px center, | ||
0 0; | ||
background-size: 11px, 100%; | ||
box-shadow: none; | ||
} | ||
|
||
.form__input:hover { | ||
box-shadow: 0 3px 8px 0 #3d4e6133; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
<form>
tag should not be self-closing. It should have a separate closing tag</form>
instead of using a self-closing syntax. This is important for proper HTML structure and to ensure that the form elements are correctly nested within the form.