Solution #379
Open
Solution #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylhnatiuk
suggested changes
Nov 2, 2023
cinema/models.py
Outdated
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor) |
cinema/models.py
Outdated
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor) | ||
| genres = models.ManyToManyField(Genre) |
cinema/views.py
Outdated
| def patch(self, request, *args, **kwargs): | ||
| actor = self.get_object() | ||
| serializer = ActorSerializer(actor, data=request.data, partial=True) | ||
| if serializer.is_valid(): |
There was a problem hiding this comment.
use serializer.is_valid(raise_exception=True)
There was a problem hiding this comment.
I fixed the bugs, ran git add . and ran git push origin develop
vasylhnatiuk
suggested changes
Nov 2, 2023
There was a problem hiding this comment.
did you do a commit like here?https://github.com/mate-academy/py-task-guideline/blob/main/README.md#implement-the-solution
ArsenPidhoretskyi
suggested changes
Nov 3, 2023
cinema/views.py
Outdated
| if serializer.is_valid(): | ||
| def post(self, request): | ||
| serializer = GenreSerializer(data=request.data) | ||
| if serializer.is_valid(raise_exception=True): |
There was a problem hiding this comment.
Suggested change
| if serializer.is_valid(raise_exception=True): | |
| serializer.is_valid(raise_exception=True): |
redundant if statement
ArsenPidhoretskyi
suggested changes
Nov 3, 2023
cinema/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| path("movies/", movie_list, name="movie-list"), | ||
| path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
| path("", include(router.urls)), |
There was a problem hiding this comment.
BTW, no need to include when basepath not provided. Use: urlpatterns = [list of urls] + router.urls
Yurnerroo
suggested changes
Nov 3, 2023
cinema/models.py
Outdated
| first_name = models.CharField(max_length=255) | ||
| last_name = models.CharField(max_length=255) | ||
|
|
||
| def __str__(self): |
There was a problem hiding this comment.
add return annotations throughout the code
Yurnerroo
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.