Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #379

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# Generated by Django 4.1 on 2023-11-02 12:05

from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("cinema", "0001_initial"),
]

operations = [
migrations.CreateModel(
name="Actor",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("first_name", models.CharField(max_length=255)),
("last_name", models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name="CinemaHall",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255)),
("rows", models.IntegerField()),
("seats_in_row", models.IntegerField()),
],
),
migrations.CreateModel(
name="Genre",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255, unique=True)),
],
),
migrations.AddField(
model_name="movie",
name="actors",
field=models.ManyToManyField(to="cinema.actor"),
),
migrations.AddField(
model_name="movie",
name="genres",
field=models.ManyToManyField(to="cinema.genre"),
),
]
26 changes: 26 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,35 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self):
return self.name


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add return annotations throughout the code

return f"{self.first_name} {self.last_name}"


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.IntegerField()
seats_in_row = models.IntegerField()

def __str__(self):
return self.name


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
actors = models.ManyToManyField(Actor)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add related name

genres = models.ManyToManyField(Genre)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add related name

duration = models.IntegerField()

def __str__(self):
Expand Down
101 changes: 96 additions & 5 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,115 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Movie, CinemaHall, Actor, Genre


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()
actors = serializers.PrimaryKeyRelatedField(
many=True,
queryset=Actor.objects.all()
)
genres = serializers.PrimaryKeyRelatedField(
many=True,
queryset=Genre.objects.all()
)

def create(self, validated_data):
return Movie.objects.create(**validated_data)
actors_data = validated_data.pop("actors")
genres_data = validated_data.pop("genres")
movie = Movie.objects.create(**validated_data)
movie.actors.set(actors_data)
movie.genres.set(genres_data)
return movie

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
instance.title = validated_data.get(
"title",
instance.title
)
instance.description = validated_data.get(
"description", instance.description
"description",
instance.description
)
instance.duration = validated_data.get(
"duration",
instance.duration
)
instance.duration = validated_data.get("duration", instance.duration)

actors_data = validated_data.get("actors")
genres_data = validated_data.get("genres")

if actors_data is not None:
instance.actors.set(actors_data)
if genres_data is not None:
instance.genres.set(genres_data)

instance.save()

return instance


class GenreSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Genre.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get(
"name",
instance.name
)
instance.save()
return instance


class ActorSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
first_name = serializers.CharField(max_length=255)
last_name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Actor.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.first_name = validated_data.get(
"first_name",
instance.first_name
)
instance.last_name = validated_data.get(
"last_name",
instance.last_name
)
instance.save()
return instance


class CinemaHallSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)
rows = serializers.IntegerField()
seats_in_row = serializers.IntegerField()

def create(self, validated_data):
return CinemaHall.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get(
"name",
instance.name
)
instance.rows = validated_data.get(
"rows",
instance.rows
)
instance.seats_in_row = validated_data.get(
"seats_in_row",
instance.seats_in_row
)
instance.save()
return instance
40 changes: 36 additions & 4 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,42 @@
from django.urls import path
from django.urls import path, include
from rest_framework import routers
from cinema.views import (
CinemaHallViewSet,
MovieViewSet,
ActorDetail,
ActorList,
GenreList,
GenreDetail
)

from cinema.views import movie_list, movie_detail
router = routers.DefaultRouter()
router.register("movies", MovieViewSet)

cinema_hall_list = CinemaHallViewSet.as_view(actions={
"get": "list",
"post": "create"
})

cinema_hall_detail = CinemaHallViewSet.as_view(actions={
"get": "retrieve",
"put": "update",
"patch": "partial_update",
"delete": "destroy",
})

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
path("", include(router.urls)),
path("cinema_halls/", cinema_hall_list, name="cinema-hall-list"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, no need to include when basepath not provided. Use: urlpatterns = [list of urls] + router.urls

path(
"cinema_halls/<int:pk>/",
cinema_hall_detail,
name="cinema-hall-detail"
),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
path("actors/", ActorList.as_view(), name="actor-list"),
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
]


app_name = "cinema"
Loading
Loading