Solution #687
Solution #687
Conversation
cinema/serializers.py
Outdated
| if actors is not None: | ||
| instance.actors.set(actors) | ||
| if genres is not None: | ||
| instance.genres.set(genres) |
There was a problem hiding this comment.
You've implemented this logic in your Movie model. DRY (Don't Repeat Yourself)
| class ActorList(generics.ListCreateAPIView): | ||
| queryset = Actor.objects.all() | ||
| serializer_class = ActorSerializer | ||
|
|
There was a problem hiding this comment.
You have to use GenericAPIView here. Check README.md
"·For the Actor model use a GenericAPIView"
cinema/views.py
Outdated
| if serializer.is_valid(): | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_201_CREATED) | ||
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) |
There was a problem hiding this comment.
You can simplify it using:
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
cinema/views.py
Outdated
| serializer = GenreSerializer(genres, many=True) | ||
| return Response(serializer.data) | ||
|
|
||
| def post(self, request): |
There was a problem hiding this comment.
Don't forget to add type hints to parameters and return
cinema/serializers.py
Outdated
| from rest_framework import serializers | ||
| from cinema.models import Actor, Genre, CinemaHall, Movie |
cinema/serializers.py
Outdated
| class ActorSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = Actor | ||
| fields = ["id", "first_name", "last_name"] | ||
|
|
||
|
|
||
| class GenreSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = Genre | ||
| fields = ["id", "name"] | ||
|
|
||
|
|
||
| class CinemaHallSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = CinemaHall | ||
| fields = ["id", "name", "rows", "seats_in_row"] |
There was a problem hiding this comment.
Yeah, it's a way easier to do it in this way, however we'll learn it in API Serializers topic, thus you have to implement it via a usual Serializer ;)
cinema/serializers.py
Outdated
| actors = serializers.PrimaryKeyRelatedField( | ||
| many=True, | ||
| queryset=Actor.objects.all() | ||
| ) | ||
| genres = serializers.PrimaryKeyRelatedField( | ||
| many=True, | ||
| queryset=Genre.objects.all() | ||
| ) |
cinema/urls.py
Outdated
| from django.urls import path, include | ||
| from rest_framework.routers import DefaultRouter | ||
| from cinema.views import ( |
| path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"), | ||
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path("", include(router.urls)), |
There was a problem hiding this comment.
you have movies at the top of the list and now to connect router with "movies" url and viewset. Don't you think it'll conflict?
cinema/views.py
Outdated
| from rest_framework.decorators import api_view | ||
| from rest_framework.response import Response | ||
| from rest_framework import status | ||
|
|
||
| from rest_framework.views import APIView | ||
| from rest_framework import status, generics, viewsets, mixins | ||
| from django.shortcuts import get_object_or_404 | ||
| from rest_framework.request import Request | ||
| from typing import Any |
There was a problem hiding this comment.
reorder imports + split different groups
No description provided.