Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #687

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
# Generated by Django 4.1 on 2024-09-28 12:57

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("cinema", "0001_initial"),
]

operations = [
migrations.CreateModel(
name="Actor",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("first_name", models.CharField(max_length=255)),
("last_name", models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name="CinemaHall",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255)),
("rows", models.PositiveIntegerField()),
("seats_in_row", models.PositiveIntegerField()),
],
),
migrations.CreateModel(
name="Genre",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255, unique=True)),
],
),
migrations.AlterField(
model_name="movie",
name="duration",
field=models.PositiveIntegerField(),
),
migrations.AddField(
model_name="movie",
name="actors",
field=models.ManyToManyField(to="cinema.actor"),
),
migrations.AddField(
model_name="movie",
name="genres",
field=models.ManyToManyField(to="cinema.genre"),
),
]
37 changes: 36 additions & 1 deletion cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,45 @@
from django.db import models


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self):
return f"{self.first_name} {self.last_name}"


class Genre(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self):
return self.name


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.PositiveIntegerField()
seats_in_row = models.PositiveIntegerField()

def __str__(self):
return self.name


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
duration = models.IntegerField()
duration = models.PositiveIntegerField()
actors = models.ManyToManyField(Actor, related_name="movies")
genres = models.ManyToManyField(Genre, related_name="movies")

def save(self, *args, **kwargs):
super().save(*args, **kwargs)

def set_related_fields(self, actors=None, genres=None):
if actors is not None:
self.actors.set(actors)
if genres is not None:
self.genres.set(genres)

def __str__(self):
return self.title
103 changes: 96 additions & 7 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,113 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Actor, Genre, CinemaHall, Movie


class ActorSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
first_name = serializers.CharField(max_length=100)
last_name = serializers.CharField(max_length=100)

def create(self, validated_data):
return Actor.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.first_name = validated_data.get(
"first_name",
instance.first_name
)
instance.last_name = validated_data.get(
"last_name",
instance.last_name
)
instance.save()
return instance


class GenreSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=100)

def create(self, validated_data):
return Genre.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get("name", instance.name)
instance.save()
return instance


class CinemaHallSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=100)
rows = serializers.IntegerField()
seats_in_row = serializers.IntegerField()

def create(self, validated_data):
return CinemaHall.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get("name", instance.name)
instance.rows = validated_data.get("rows", instance.rows)
instance.seats_in_row = validated_data.get(
"seats_in_row",
instance.seats_in_row
)
instance.save()
return instance


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()
actors = ActorSerializer(many=True, required=False)
genres = GenreSerializer(many=True, required=False)

def create(self, validated_data):
return Movie.objects.create(**validated_data)
def create(self, validated_data: dict) -> Movie:
actors_data = validated_data.pop("actors", [])
genres_data = validated_data.pop("genres", [])
movie = Movie.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
if actors_data:
for actor_data in actors_data:
actor = Actor.objects.get(id=actor_data["id"])
movie.actors.add(actor)

if genres_data:
for genre_data in genres_data:
genre = Genre.objects.get(id=genre_data["id"])
movie.genres.add(genre)

return movie

def update(self, instance: Movie, validated_data: dict) -> Movie:
actors_data = validated_data.pop("actors", None)
genres_data = validated_data.pop("genres", None)

instance.title = validated_data.get(
"title", instance.title
)
instance.description = validated_data.get(
"description", instance.description
)
instance.duration = validated_data.get("duration", instance.duration)
instance.duration = validated_data.get(
"duration",
instance.duration
)

instance.save()
if actors_data is not None:
instance.actors.clear()
for actor_data in actors_data:
actor = Actor.objects.get(id=actor_data["id"])
instance.actors.add(actor)

if genres_data is not None:
instance.genres.clear()
for genre_data in genres_data:
genre = Genre.objects.get(id=genre_data["id"])
instance.genres.add(genre)

instance.save()
return instance
29 changes: 23 additions & 6 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,27 @@
from django.urls import path
from django.urls import path, include
from rest_framework.routers import DefaultRouter

from cinema.views import movie_list, movie_detail
from cinema.views import (
movie_list,
movie_detail,
GenreList,
GenreDetail,
ActorList,
ActorDetail,
CinemaHallViewSet,
MovieViewSet,
)

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
]
router = DefaultRouter()
router.register(r"cinema_halls", CinemaHallViewSet, basename="cinema_hall")
router.register(r"movies", MovieViewSet)

app_name = "cinema"

urlpatterns = [
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
path("", include(router.urls)),
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have movies at the top of the list and now to connect router with "movies" url and viewset. Don't you think it'll conflict?

Loading
Loading