Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #648

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,67 @@
from abc import ABC
from typing import Any


class IntegerRange:
pass
def __init__(self, min_amount: int, max_amount: int) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, owner: Any, name: str) -> Any:
self.protected_name = f"_{name}"

def __get__(self, instance: Any, owner: Any) -> str:
return getattr(instance, self.protected_name)
Comment on lines +13 to +14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __get__ method in the IntegerRange class should return the value as a string, as indicated by its return type annotation -> str. Consider converting the returned value to a string.


def __set__(self, instance: Any, value: Any) -> None:
if not isinstance(value, int):
raise TypeError(f"{self.protected_name}"
f" must be an integer.")
if not self.min_amount <= value <= self.max_amount:
raise ValueError(
f"{self.protected_name} must be between"
f" {self.min_amount} and {self.max_amount}."
)
setattr(instance, self.protected_name, value)


class Visitor:
pass
def __init__(self, name: str, age: int,
weight: int | float, height: int | float) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
def __init__(self) -> None:
pass


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
height = IntegerRange(80, 120)
weight = IntegerRange(20, 50)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
height = IntegerRange(120, 220)
weight = IntegerRange(50, 120)


class Slide:
pass
def __init__(self, name: str, limitation_class: type) -> None:
self.name = name
self.limitation_class = limitation_class
Comment on lines +55 to +57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that limitation_class is a subclass of SlideLimitationValidator to prevent incorrect usage. This will ensure that only valid limitation classes are used with the Slide class.


def can_access(self, visitor: Visitor) -> bool:
try:
validator = self.limitation_class()
validator.age = visitor.age
validator.weight = visitor.weight
validator.height = visitor.height
return True
except (TypeError, ValueError):
return False
Loading