Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #350

wants to merge 2 commits into from

Conversation

IvanMozhar
Copy link

No description provided.

app/main.py Outdated
Comment on lines 59 to 63
self.field = {}
for ship_start, ship_end in ships:
ship = Ship(ship_start, ship_end)
for deck in ship.decks:
self.field[(deck.row, deck.column)] = ship
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use comprehension

app/main.py Outdated
Comment on lines 65 to 68
def fire(
self,
location: tuple
) -> str:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def fire(
self,
location: tuple
) -> str:
def fire(self, location: tuple) -> str:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix everywhere

app/main.py Outdated
Comment on lines 13 to 24
pass
@classmethod
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a classmethod?

@IvanMozhar IvanMozhar requested a review from vsmutok November 20, 2023 03:47
Copy link

@pavlejviki pavlejviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants