-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #350
base: master
Are you sure you want to change the base?
Solution #350
Conversation
app/main.py
Outdated
self.field = {} | ||
for ship_start, ship_end in ships: | ||
ship = Ship(ship_start, ship_end) | ||
for deck in ship.decks: | ||
self.field[(deck.row, deck.column)] = ship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to use comprehension
app/main.py
Outdated
def fire( | ||
self, | ||
location: tuple | ||
) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def fire( | |
self, | |
location: tuple | |
) -> str: | |
def fire(self, location: tuple) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix everywhere
app/main.py
Outdated
pass | ||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a classmethod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.