Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #435

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #435

wants to merge 3 commits into from

Conversation

sdannyk
Copy link

@sdannyk sdannyk commented Apr 20, 2024

No description provided.

app/main.py Outdated
deck = self.get_deck(row, column)
if deck:
deck.is_alive = False
deck.is_hit = True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant
deck.is_alive always equal to not deck.is_hit

app/main.py Outdated
Comment on lines 47 to 49
for row in range(location[0][0], location[1][0] + 1):
for column in range(location[0][1], location[1][1] + 1):
self.field[(row, column)] = ship

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can iterate over ship.decks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants