Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #522

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #522

wants to merge 3 commits into from

Conversation

julia4406
Copy link

No description provided.

julia4406 and others added 2 commits December 29, 2024 12:42
Removed methods descriptions and executable block "__main__"
Copy link

@L1nk3rrr L1nk3rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Remove redundant else and your code will be totally good!

app/main.py Outdated
Deck(row_s, point) for point
in range(column_s, column_e + 1)
]
else:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant else

app/main.py Outdated
def fire(self, location: tuple) -> str:
if location not in self.field.keys():
return "Miss!"
else:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant else

app/main.py Outdated
ship.fire(*location)
if ship.is_drowned:
return "Sunk!"
else:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant else

@julia4406 julia4406 requested a review from L1nk3rrr January 2, 2025 12:35
Copy link

@L1nk3rrr L1nk3rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants