Solution #1421
Solution #1421
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your solution meets the task requirements effectively, and the code is well-structured. Just a small note: using frozenset for kwargs works well for hashable types, but be cautious if non-hashable types might be passed, as this could cause errors. Keep up the excellent work and consider documenting this requirement for future clarity. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @wraps(func) | ||
| def wrapper(*args, **kwargs) -> Any: | ||
| key = (args, frozenset(kwargs.items())) |
There was a problem hiding this comment.
Using frozenset to create a key from kwargs is generally fine, but it assumes that all keyword arguments are hashable. If there's a possibility of non-hashable types being passed as keyword arguments, this could raise an error. Consider handling such cases or documenting this requirement.
No description provided.