Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
from typing import Callable
from typing import Callable, Any
from functools import wraps


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_store = {}

@wraps(func)
def wrapper(*args, **kwargs) -> Any:
key = (args, frozenset(kwargs.items()))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using frozenset to create a key from kwargs is generally fine, but it assumes that all keyword arguments are hashable. If there's a possibility of non-hashable types being passed as keyword arguments, this could raise an error. Consider handling such cases or documenting this requirement.

if key in cache_store:
print("Getting from cache")
return cache_store[key]
else:
print("Calculating new result")
result = func(*args, **kwargs)
cache_store[key] = result
return result
return wrapper