my decorator cash #1448
my decorator cash #1448
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and handles function arguments effectively. While the use of frozenset is clever, remember to consider cases where keyword arguments might be mutable, as this could lead to a TypeError. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| cache_data = {} | ||
|
|
||
| def wrapper(*args, **kwargs): | ||
| key = (args, frozenset(kwargs.items())) |
There was a problem hiding this comment.
The use of frozenset to convert kwargs.items() into a hashable type is correct, but it assumes that all keyword arguments are hashable. If any of the keyword arguments are mutable (e.g., lists or dictionaries), this will raise a TypeError. Consider adding a check or handling for non-hashable keyword arguments.
No description provided.