Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my decorator cash #1448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

my decorator cash #1448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,19 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_data = {}

def wrapper(*args, **kwargs):
key = (args, frozenset(kwargs.items()))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of frozenset to convert kwargs.items() into a hashable type is correct, but it assumes that all keyword arguments are hashable. If any of the keyword arguments are mutable (e.g., lists or dictionaries), this will raise a TypeError. Consider adding a check or handling for non-hashable keyword arguments.


if key in cache_data:
print("Getting from cache")
return cache_data[key]

print("Calculating new result")
result = func(*args, **kwargs)
cache_data[key] = result
return result

return wrapper

Loading