Solution #1449
Solution #1449
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your solution meets the task requirements and constraints effectively. The decorator works well with multiple functions and handles caching as expected. While there's a minor issue with the use of frozenset for keyword arguments, which could lead to inconsistent caching behavior, it's a small tweak that can be easily addressed. Keep up the good work and consider using a sorted tuple of items for the cache key to ensure consistent behavior. Well done! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def wrapper(*args, **kwargs) -> Any: | ||
| if func not in cache_store: | ||
| cache_store[func] = {} | ||
| key = (args, frozenset(kwargs.items())) |
There was a problem hiding this comment.
Using frozenset to store keyword arguments in the cache key can lead to issues when the order of keyword arguments is different but the values are the same. Consider using a sorted tuple of items instead: tuple(sorted(kwargs.items())).
No description provided.